From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=4bji=ZG=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 81A45C432C3
	for <netdev@archiver.kernel.org>; Thu, 14 Nov 2019 16:31:34 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 57F9E20718
	for <netdev@archiver.kernel.org>; Thu, 14 Nov 2019 16:31:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1573749094;
	bh=Eiu1ljzVsvSnNn/8kaosmDXL7hYgMiRj97SQIA1EhyI=;
	h=Date:From:To:Cc:Subject:List-ID:From;
	b=0L5livSj67mmNIWoBlP9uKTuBMIko6wql1shpiakIJhStClZDnIUQH0fEX9SvH4KE
	 0jcKAZi2Gqd+e4j+g+UMUFq6ACXJmJM1/II9kyekz2G2wTz3pgnSRCAgHm31O3CG6E
	 86zPh7LydlTrSsd0RlghF2r0rh6QnonRHOj707Ok=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726717AbfKNQbd (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 14 Nov 2019 11:31:33 -0500
Received: from mail.stusta.mhn.de ([141.84.69.5]:34434 "EHLO
        mail.stusta.mhn.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726516AbfKNQbd (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 14 Nov 2019 11:31:33 -0500
X-Greylist: delayed 416 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Nov 2019 11:31:33 EST
Received: from [127.0.0.1] (localhost [127.0.0.1])
        by mail.stusta.mhn.de (Postfix) with ESMTPSA id 47DRdZ2MZxzVw;
        Thu, 14 Nov 2019 17:24:33 +0100 (CET)
Date:   Thu, 14 Nov 2019 18:24:32 +0200
From:   Adrian Bunk <bunk@kernel.org>
To:     Dan Murphy <dmurphy@ti.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org
Subject: dp83867: Why does ti,fifo-depth set only TX, and why is it mandatory?
Message-ID: <20191114162431.GA21979@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

Hi,

looking at the ti,fifo-depth property to set the TX FIFO Depth in the 
dp83867 driver I was wondering:

1. Why does it set only TX?
Is there a reason why TX needs setting but RX does not?
(RX FIFO Depth is SGMII-only, but that's what I am using)

2. Why is it a mandatory property?
Perhaps I am missing something obvious, but why can't the driver either
leave the value untouched or set the maximum when nothing is configured?

Thanks in advance
Adrian