netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: <netdev@vger.kernel.org>, <davem@davemloft.net>
Cc: <kernel-team@fb.com>, <brouer@redhat.com>, <ilias.apalodimas@linaro.org>
Subject: [net-next PATCH v2 0/2] Change page_pool timeout handling
Date: Thu, 14 Nov 2019 08:37:13 -0800	[thread overview]
Message-ID: <20191114163715.4184099-1-jonathan.lemon@gmail.com> (raw)

It isn't safe to remove the page pool until all in-flight pages 
are returned.  If the pages are handed up the stack, it might be
a while before they are returned.

The page pool can also be used independently of xdp, so it shouldn't
be depending on timeout handling from the xdp memory model.  Change
things around so the pool handles its own timeout.

v2:
 - fix wording in commit log
 - fix compile error for !PAGE_POOL case
 - revise tracepoint handling

Jonathan Lemon (2):
  page_pool: do not release pool until inflight == 0.
  page_pool: remove hold/release count from tracepoints

 .../net/ethernet/stmicro/stmmac/stmmac_main.c |   4 +-
 include/net/page_pool.h                       |  54 +++-----
 include/net/xdp_priv.h                        |   4 -
 include/trace/events/page_pool.h              |  24 ++--
 include/trace/events/xdp.h                    |  19 +--
 net/core/page_pool.c                          | 123 ++++++++++-------
 net/core/xdp.c                                | 125 +++++++-----------
 7 files changed, 152 insertions(+), 201 deletions(-)

-- 
2.17.1


             reply	other threads:[~2019-11-14 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 16:37 Jonathan Lemon [this message]
2019-11-14 16:37 ` [net-next PATCH v2 1/2] page_pool: do not release pool until inflight == 0 Jonathan Lemon
2019-11-14 21:27   ` Jesper Dangaard Brouer
2019-11-14 16:37 ` [net-next PATCH v2 2/2] page_pool: remove hold/release count from tracepoints Jonathan Lemon
2019-11-14 20:53   ` kbuild test robot
2019-11-14 21:07   ` Jesper Dangaard Brouer
2019-11-14 21:56     ` Jonathan Lemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191114163715.4184099-1-jonathan.lemon@gmail.com \
    --to=jonathan.lemon@gmail.com \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).