Re: [net-next PATCH v2 2/2] page_pool: remove hold/release count from tracepoints

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2810 bytes --]

Hi Jonathan,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v5.4-rc7 next-20191114]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jonathan-Lemon/page_pool-do-not-release-pool-until-inflight-0/20191115-024705
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 75a1ccfe6c726ba33a2f9859d39deb2eba620583
config: x86_64-randconfig-s1-20191115 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from net//core/page_pool.c:19:0:
   include/trace/events/page_pool.h:57:1: error: macro "TRACE_EVENT" requires 6 arguments, but only 5 given
    );
    ^
   include/trace/events/page_pool.h:38:1: warning: data definition has no type or storage class
    TRACE_EVENT(page_pool_page_release,
    ^~~~~~~~~~~
   include/trace/events/page_pool.h:38:1: error: type defaults to 'int' in declaration of 'TRACE_EVENT' [-Werror=implicit-int]
   net//core/page_pool.c: In function '__page_pool_clean_page':
>> net//core/page_pool.c:225:2: error: implicit declaration of function 'trace_page_pool_page_release'; did you mean 'trace_page_pool_page_hold'? [-Werror=implicit-function-declaration]
     trace_page_pool_page_release(pool, page);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
     trace_page_pool_page_hold
   cc1: some warnings being treated as errors

vim +225 net//core/page_pool.c

   208	
   209	/* Cleanup page_pool state from page */
   210	static void __page_pool_clean_page(struct page_pool *pool,
   211					   struct page *page)
   212	{
   213		dma_addr_t dma;
   214	
   215		if (!(pool->p.flags & PP_FLAG_DMA_MAP))
   216			goto skip_dma_unmap;
   217	
   218		dma = page->dma_addr;
   219		/* DMA unmap */
   220		dma_unmap_page_attrs(pool->p.dev, dma,
   221				     PAGE_SIZE << pool->p.order, pool->p.dma_dir,
   222				     DMA_ATTR_SKIP_CPU_SYNC);
   223		page->dma_addr = 0;
   224	skip_dma_unmap:
 > 225		trace_page_pool_page_release(pool, page);
   226		/* This may be the last page returned, releasing the pool, so
   227		 * it is not safe to reference pool afterwards.
   228		 */
   229		atomic_inc(&pool->pages_state_release_cnt);
   230	}
   231	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35230 bytes --]