From: Jiri Pirko <jiri@resnulli.us>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
nirranjan@chelsio.com, vishal@chelsio.com, dt@chelsio.com
Subject: Re: [PATCH net-next v3 2/2] cxgb4: add TC-MATCHALL classifier ingress offload
Date: Fri, 15 Nov 2019 14:53:18 +0100 [thread overview]
Message-ID: <20191115135318.GB2158@nanopsycho> (raw)
In-Reply-To: <418c2bbf879fa75a8a3170d8523235f9b16af595.1573818409.git.rahul.lakkireddy@chelsio.com>
Fri, Nov 15, 2019 at 01:14:21PM CET, rahul.lakkireddy@chelsio.com wrote:
[...]
>@@ -26,9 +37,13 @@ struct cxgb4_tc_matchall {
> };
>
> int cxgb4_tc_matchall_replace(struct net_device *dev,
>- struct tc_cls_matchall_offload *cls_matchall);
>+ struct tc_cls_matchall_offload *cls_matchall,
>+ bool ingress);
> int cxgb4_tc_matchall_destroy(struct net_device *dev,
>- struct tc_cls_matchall_offload *cls_matchall);
>+ struct tc_cls_matchall_offload *cls_matchall,
>+ bool ingress);
>+int cxgb4_tc_matchall_stats(struct net_device *dev,
>+ struct tc_cls_matchall_offload *cls_matchall);
Hmm, you only add stats function in this second patch. Does that mean
you don't care for stats in egress?
From looking at cxgb_setup_tc_matchall() looks like I'm right.
Why?
>
> int cxgb4_init_tc_matchall(struct adapter *adap);
> void cxgb4_cleanup_tc_matchall(struct adapter *adap);
>--
>2.24.0
>
next prev parent reply other threads:[~2019-11-15 13:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 12:14 [PATCH net-next v3 0/2] cxgb4: add TC-MATCHALL classifier offload Rahul Lakkireddy
2019-11-15 12:14 ` [PATCH net-next v3 1/2] cxgb4: add TC-MATCHALL classifier egress offload Rahul Lakkireddy
2019-11-15 13:58 ` Jiri Pirko
2019-11-15 15:08 ` Rahul Lakkireddy
2019-11-15 15:32 ` Jiri Pirko
2019-11-15 18:51 ` Jakub Kicinski
2019-11-15 19:00 ` Rahul Lakkireddy
2019-11-15 19:28 ` Jakub Kicinski
2019-11-15 12:14 ` [PATCH net-next v3 2/2] cxgb4: add TC-MATCHALL classifier ingress offload Rahul Lakkireddy
2019-11-15 13:53 ` Jiri Pirko [this message]
2019-11-15 15:10 ` Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115135318.GB2158@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dt@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).