From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22030C432C3 for ; Fri, 15 Nov 2019 15:16:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 017E820733 for ; Fri, 15 Nov 2019 15:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727625AbfKOPQx (ORCPT ); Fri, 15 Nov 2019 10:16:53 -0500 Received: from stargate.chelsio.com ([12.32.117.8]:15999 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727412AbfKOPQx (ORCPT ); Fri, 15 Nov 2019 10:16:53 -0500 Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id xAFFGgIQ023070; Fri, 15 Nov 2019 07:16:43 -0800 Date: Fri, 15 Nov 2019 20:38:30 +0530 From: Rahul Lakkireddy To: Jiri Pirko Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, davem@davemloft.net, nirranjan@chelsio.com, vishal@chelsio.com, dt@chelsio.com Subject: Re: [PATCH net-next v3 1/2] cxgb4: add TC-MATCHALL classifier egress offload Message-ID: <20191115150824.GA14296@chelsio.com> References: <5b5af4a7ec3a6c9bc878046f4670a2838bbbe718.1573818408.git.rahul.lakkireddy@chelsio.com> <20191115135845.GC2158@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191115135845.GC2158@nanopsycho> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Friday, November 11/15/19, 2019 at 14:58:45 +0100, Jiri Pirko wrote: > Fri, Nov 15, 2019 at 01:14:20PM CET, rahul.lakkireddy@chelsio.com wrote: > > [...] > > > >+static int cxgb4_matchall_egress_validate(struct net_device *dev, > >+ struct tc_cls_matchall_offload *cls) > >+{ > >+ struct netlink_ext_ack *extack = cls->common.extack; > >+ struct flow_action *actions = &cls->rule->action; > >+ struct port_info *pi = netdev2pinfo(dev); > >+ struct flow_action_entry *entry; > >+ u64 max_link_rate; > >+ u32 i, speed; > >+ int ret; > >+ > >+ if (cls->common.prio != 1) { > >+ NL_SET_ERR_MSG_MOD(extack, > >+ "Egress MATCHALL offload must have prio 1"); > > I don't understand why you need it to be prio 1. This is to maintain rule ordering with the kernel. Jakub has suggested this in my earlier series [1][2]. I see similar checks in various drivers (mlx5 and nfp), while offloading matchall with policer. [1] http://patchwork.ozlabs.org/patch/1194936/#2304413 [2] http://patchwork.ozlabs.org/patch/1194301/#2303749 Thanks, Rahul