From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A409C432C3 for ; Fri, 15 Nov 2019 15:19:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D28DE20733 for ; Fri, 15 Nov 2019 15:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727520AbfKOPTI (ORCPT ); Fri, 15 Nov 2019 10:19:08 -0500 Received: from stargate.chelsio.com ([12.32.117.8]:10909 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727412AbfKOPTH (ORCPT ); Fri, 15 Nov 2019 10:19:07 -0500 Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id xAFFIxUn023083; Fri, 15 Nov 2019 07:19:00 -0800 Date: Fri, 15 Nov 2019 20:40:47 +0530 From: Rahul Lakkireddy To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, nirranjan@chelsio.com, vishal@chelsio.com, dt@chelsio.com Subject: Re: [PATCH net-next v3 2/2] cxgb4: add TC-MATCHALL classifier ingress offload Message-ID: <20191115151046.GA14367@chelsio.com> References: <418c2bbf879fa75a8a3170d8523235f9b16af595.1573818409.git.rahul.lakkireddy@chelsio.com> <20191115135318.GB2158@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191115135318.GB2158@nanopsycho> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Friday, November 11/15/19, 2019 at 14:53:18 +0100, Jiri Pirko wrote: > Fri, Nov 15, 2019 at 01:14:21PM CET, rahul.lakkireddy@chelsio.com wrote: > > [...] > > > >@@ -26,9 +37,13 @@ struct cxgb4_tc_matchall { > > }; > > > > int cxgb4_tc_matchall_replace(struct net_device *dev, > >- struct tc_cls_matchall_offload *cls_matchall); > >+ struct tc_cls_matchall_offload *cls_matchall, > >+ bool ingress); > > int cxgb4_tc_matchall_destroy(struct net_device *dev, > >- struct tc_cls_matchall_offload *cls_matchall); > >+ struct tc_cls_matchall_offload *cls_matchall, > >+ bool ingress); > >+int cxgb4_tc_matchall_stats(struct net_device *dev, > >+ struct tc_cls_matchall_offload *cls_matchall); > > Hmm, you only add stats function in this second patch. Does that mean > you don't care for stats in egress? > From looking at cxgb_setup_tc_matchall() looks like I'm right. > Why? > We're currently missing support to fetch these stats from hardware/ firmware on egress side. So, I could only implement it for the ingress side for now. > > > > int cxgb4_init_tc_matchall(struct adapter *adap); > > void cxgb4_cleanup_tc_matchall(struct adapter *adap); > >-- > >2.24.0 > > Thanks, Rahul