From: Jiri Pirko <jiri@resnulli.us>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com,
davem@davemloft.net, nirranjan@chelsio.com, vishal@chelsio.com,
dt@chelsio.com
Subject: Re: [PATCH net-next v3 1/2] cxgb4: add TC-MATCHALL classifier egress offload
Date: Fri, 15 Nov 2019 16:32:47 +0100 [thread overview]
Message-ID: <20191115153247.GD2158@nanopsycho> (raw)
In-Reply-To: <20191115150824.GA14296@chelsio.com>
Fri, Nov 15, 2019 at 04:08:30PM CET, rahul.lakkireddy@chelsio.com wrote:
>On Friday, November 11/15/19, 2019 at 14:58:45 +0100, Jiri Pirko wrote:
>> Fri, Nov 15, 2019 at 01:14:20PM CET, rahul.lakkireddy@chelsio.com wrote:
>>
>> [...]
>>
>>
>> >+static int cxgb4_matchall_egress_validate(struct net_device *dev,
>> >+ struct tc_cls_matchall_offload *cls)
>> >+{
>> >+ struct netlink_ext_ack *extack = cls->common.extack;
>> >+ struct flow_action *actions = &cls->rule->action;
>> >+ struct port_info *pi = netdev2pinfo(dev);
>> >+ struct flow_action_entry *entry;
>> >+ u64 max_link_rate;
>> >+ u32 i, speed;
>> >+ int ret;
>> >+
>> >+ if (cls->common.prio != 1) {
>> >+ NL_SET_ERR_MSG_MOD(extack,
>> >+ "Egress MATCHALL offload must have prio 1");
>>
>> I don't understand why you need it to be prio 1.
>
>This is to maintain rule ordering with the kernel. Jakub has suggested
>this in my earlier series [1][2]. I see similar checks in various
>drivers (mlx5 and nfp), while offloading matchall with policer.
I don't think that is correct. If matchall is the only filter there, it
does not matter which prio is it. It matters only in case there are
other filters.
The code should just check for other filters and forbid to insert the
rule if other filters have higher prio (lower number).
>
>[1] http://patchwork.ozlabs.org/patch/1194936/#2304413
>[2] http://patchwork.ozlabs.org/patch/1194301/#2303749
>
>Thanks,
>Rahul
next prev parent reply other threads:[~2019-11-15 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 12:14 [PATCH net-next v3 0/2] cxgb4: add TC-MATCHALL classifier offload Rahul Lakkireddy
2019-11-15 12:14 ` [PATCH net-next v3 1/2] cxgb4: add TC-MATCHALL classifier egress offload Rahul Lakkireddy
2019-11-15 13:58 ` Jiri Pirko
2019-11-15 15:08 ` Rahul Lakkireddy
2019-11-15 15:32 ` Jiri Pirko [this message]
2019-11-15 18:51 ` Jakub Kicinski
2019-11-15 19:00 ` Rahul Lakkireddy
2019-11-15 19:28 ` Jakub Kicinski
2019-11-15 12:14 ` [PATCH net-next v3 2/2] cxgb4: add TC-MATCHALL classifier ingress offload Rahul Lakkireddy
2019-11-15 13:53 ` Jiri Pirko
2019-11-15 15:10 ` Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115153247.GD2158@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dt@chelsio.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).