From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, davem@davemloft.net,
thomas.petazzoni@bootlin.com, matteo.croce@redhat.com
Subject: Re: [PATCH net-next 2/3] net: page_pool: add the possibility to sync DMA memory for non-coherent devices
Date: Fri, 15 Nov 2019 18:53:31 +0200 [thread overview]
Message-ID: <20191115165331.GA2518@localhost.localdomain> (raw)
In-Reply-To: <86A76A45-2CF5-46C4-A7CF-0EC3CB79944B@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
[...]
> > > >
> > > > Okay, then i guess the flag is a better fit for this.
> > > > The only difference would be that the sync semantics will be
> > > > done on 'per
> > > > packet' basis, instead of 'per pool', but that should be fine
> > > > for our cases.
> > >
> > > Ack, fine for me.
> > > Do you think when checking for PP_FLAG_DMA_SYNC_DEV we should even
> > > verify
> > > PP_FLAG_DMA_MAP? Something like:
> > >
> > > if ((pool->p.flags & (PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV)) ==
> > > (PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV))
> > > page_pool_dma_sync_for_device();
> > >
> > > Regards,
> > > Lorenzo
> >
> > I think it's better to do the check once on the pool registration and
> > maybe
> > refuse to allocate the pool? Syncing without mapping doesn't really make
> > sense
>
> +1.
ack, will post v3 soon.
Regards,
Lorenzo
> --
> Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-11-15 16:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-10 12:09 [PATCH net-next 0/3] add DMA sync capability to page_pool API Lorenzo Bianconi
2019-11-10 12:09 ` [PATCH net-next 1/3] net: mvneta: rely on page_pool_recycle_direct in mvneta_run_xdp Lorenzo Bianconi
2019-11-10 12:09 ` [PATCH net-next 2/3] net: page_pool: add the possibility to sync DMA memory for non-coherent devices Lorenzo Bianconi
2019-11-11 16:48 ` Jesper Dangaard Brouer
2019-11-11 19:11 ` Lorenzo Bianconi
2019-11-13 8:29 ` Jesper Dangaard Brouer
2019-11-14 18:48 ` Jonathan Lemon
2019-11-14 18:53 ` Ilias Apalodimas
2019-11-14 20:27 ` Jonathan Lemon
2019-11-14 20:42 ` Ilias Apalodimas
2019-11-14 21:04 ` Jonathan Lemon
2019-11-14 21:43 ` Jesper Dangaard Brouer
2019-11-15 7:05 ` Ilias Apalodimas
2019-11-15 7:49 ` Lorenzo Bianconi
2019-11-15 8:03 ` Ilias Apalodimas
2019-11-15 16:47 ` Jonathan Lemon
2019-11-15 16:53 ` Lorenzo Bianconi [this message]
2019-11-15 7:17 ` Ilias Apalodimas
2019-11-10 12:09 ` [PATCH net-next 3/3] net: mvneta: get rid of huge DMA sync in mvneta_rx_refill Lorenzo Bianconi
2019-11-14 18:14 ` Jonathan Lemon
2019-11-14 18:18 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115165331.GA2518@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=jonathan.lemon@gmail.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=matteo.croce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).