From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FB9C432C0 for ; Tue, 19 Nov 2019 11:39:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6F712067D for ; Tue, 19 Nov 2019 11:39:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bOpfvTEp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727976AbfKSLjF (ORCPT ); Tue, 19 Nov 2019 06:39:05 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:48551 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727529AbfKSLjE (ORCPT ); Tue, 19 Nov 2019 06:39:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574163543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jmfnhk3LBCDD/hpnlyFXlGUe8AU9t88orirFnAYVQOM=; b=bOpfvTEpMnhmjdsRlY2GqL79va4O3wB3yJh+kvOdm98+obTUB37PbmDtx0NUr4TVXnyaKz u9RegVZHF3z81yBxgHGUF1rHMcBmT180GFzI5eqDEwKfrCFgAeMEscfXwyAoZK3XFL3E6X NmblRbCgJcQZO2gS4qT5uhglb0gPxvc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-JZPDqvMPMjmQef2sci79GQ-1; Tue, 19 Nov 2019 06:39:00 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5488B1883523; Tue, 19 Nov 2019 11:38:59 +0000 (UTC) Received: from carbon (ovpn-200-17.brq.redhat.com [10.40.200.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id F37A05E24D; Tue, 19 Nov 2019 11:38:51 +0000 (UTC) Date: Tue, 19 Nov 2019 12:38:50 +0100 From: Jesper Dangaard Brouer To: Lorenzo Bianconi Cc: netdev@vger.kernel.org, davem@davemloft.net, ilias.apalodimas@linaro.org, lorenzo.bianconi@redhat.com, mcroce@redhat.com, jonathan.lemon@gmail.com, brouer@redhat.com Subject: Re: [PATCH v4 net-next 3/3] net: mvneta: get rid of huge dma sync in mvneta_rx_refill Message-ID: <20191119123850.5cd60c0e@carbon> In-Reply-To: <7bd772e5376af0c55e7319b7974439d4981aa167.1574083275.git.lorenzo@kernel.org> References: <7bd772e5376af0c55e7319b7974439d4981aa167.1574083275.git.lorenzo@kernel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: JZPDqvMPMjmQef2sci79GQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 18 Nov 2019 15:33:46 +0200 Lorenzo Bianconi wrote: > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet= /marvell/mvneta.c > index f7713c2c68e1..a06d109c9e80 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c [...] > @@ -2097,8 +2093,10 @@ mvneta_run_xdp(struct mvneta_port *pp, struct mvne= ta_rx_queue *rxq, > =09=09err =3D xdp_do_redirect(pp->dev, xdp, prog); > =09=09if (err) { > =09=09=09ret =3D MVNETA_XDP_DROPPED; > -=09=09=09page_pool_recycle_direct(rxq->page_pool, > -=09=09=09=09=09=09 virt_to_head_page(xdp->data)); > +=09=09=09__page_pool_put_page(rxq->page_pool, > +=09=09=09=09=09virt_to_head_page(xdp->data), > +=09=09=09=09=09xdp->data_end - xdp->data_hard_start, > +=09=09=09=09=09true); > =09=09} else { > =09=09=09ret =3D MVNETA_XDP_REDIR; > =09=09} > @@ -2107,8 +2105,10 @@ mvneta_run_xdp(struct mvneta_port *pp, struct mvne= ta_rx_queue *rxq, > =09case XDP_TX: > =09=09ret =3D mvneta_xdp_xmit_back(pp, xdp); > =09=09if (ret !=3D MVNETA_XDP_TX) > -=09=09=09page_pool_recycle_direct(rxq->page_pool, > -=09=09=09=09=09=09 virt_to_head_page(xdp->data)); > +=09=09=09__page_pool_put_page(rxq->page_pool, > +=09=09=09=09=09virt_to_head_page(xdp->data), > +=09=09=09=09=09xdp->data_end - xdp->data_hard_start, > +=09=09=09=09=09true); > =09=09break; > =09default: > =09=09bpf_warn_invalid_xdp_action(act); > @@ -2117,8 +2117,10 @@ mvneta_run_xdp(struct mvneta_port *pp, struct mvne= ta_rx_queue *rxq, > =09=09trace_xdp_exception(pp->dev, prog, act); > =09=09/* fall through */ > =09case XDP_DROP: > -=09=09page_pool_recycle_direct(rxq->page_pool, > -=09=09=09=09=09 virt_to_head_page(xdp->data)); > +=09=09__page_pool_put_page(rxq->page_pool, > +=09=09=09=09 virt_to_head_page(xdp->data), > +=09=09=09=09 xdp->data_end - xdp->data_hard_start, > +=09=09=09=09 true); This does beg for the question: Should we create an API wrapper for this in the header file? But what to name it? I know Jonathan doesn't like the "direct" part of the previous function name page_pool_recycle_direct. (I do considered calling this 'napi' instead, as it would be inline with networking use-cases, but it seemed limited if other subsystem end-up using this). Does is 'page_pool_put_page_len' sound better? But I want also want hide the bool 'allow_direct' in the API name. (As it makes it easier to identify users that uses this from softirq) Going for 'page_pool_put_page_len_napi' starts to be come rather long. --=20 Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer