* [PATCH net] ipv6/route: return if there is no fib_nh_gw_family
@ 2019-11-20 7:39 Hangbin Liu
2019-11-20 15:04 ` David Ahern
2019-11-20 20:19 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2019-11-20 7:39 UTC (permalink / raw)
To: netdev; +Cc: David Ahern, David S . Miller, Hangbin Liu
Previously we will return directly if (!rt || !rt->fib6_nh.fib_nh_gw_family)
in function rt6_probe(), but after commit cc3a86c802f0
("ipv6: Change rt6_probe to take a fib6_nh"), the logic changed to
return if there is fib_nh_gw_family.
Fixes: cc3a86c802f0 ("ipv6: Change rt6_probe to take a fib6_nh")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index e60bf8e7dd1a..3f83ea851ebf 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -634,7 +634,7 @@ static void rt6_probe(struct fib6_nh *fib6_nh)
* Router Reachability Probe MUST be rate-limited
* to no more than one per minute.
*/
- if (fib6_nh->fib_nh_gw_family)
+ if (!fib6_nh->fib_nh_gw_family)
return;
nh_gw = &fib6_nh->fib_nh_gw6;
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] ipv6/route: return if there is no fib_nh_gw_family
2019-11-20 7:39 [PATCH net] ipv6/route: return if there is no fib_nh_gw_family Hangbin Liu
@ 2019-11-20 15:04 ` David Ahern
2019-11-20 20:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2019-11-20 15:04 UTC (permalink / raw)
To: Hangbin Liu, netdev; +Cc: David S . Miller
On 11/20/19 12:39 AM, Hangbin Liu wrote:
> Previously we will return directly if (!rt || !rt->fib6_nh.fib_nh_gw_family)
> in function rt6_probe(), but after commit cc3a86c802f0
> ("ipv6: Change rt6_probe to take a fib6_nh"), the logic changed to
> return if there is fib_nh_gw_family.
>
> Fixes: cc3a86c802f0 ("ipv6: Change rt6_probe to take a fib6_nh")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> net/ipv6/route.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index e60bf8e7dd1a..3f83ea851ebf 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -634,7 +634,7 @@ static void rt6_probe(struct fib6_nh *fib6_nh)
> * Router Reachability Probe MUST be rate-limited
> * to no more than one per minute.
> */
> - if (fib6_nh->fib_nh_gw_family)
> + if (!fib6_nh->fib_nh_gw_family)
> return;
>
> nh_gw = &fib6_nh->fib_nh_gw6;
>
good catch. Thanks for the patch.
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] ipv6/route: return if there is no fib_nh_gw_family
2019-11-20 7:39 [PATCH net] ipv6/route: return if there is no fib_nh_gw_family Hangbin Liu
2019-11-20 15:04 ` David Ahern
@ 2019-11-20 20:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-11-20 20:19 UTC (permalink / raw)
To: liuhangbin; +Cc: netdev, dsahern
From: Hangbin Liu <liuhangbin@gmail.com>
Date: Wed, 20 Nov 2019 15:39:06 +0800
> Previously we will return directly if (!rt || !rt->fib6_nh.fib_nh_gw_family)
> in function rt6_probe(), but after commit cc3a86c802f0
> ("ipv6: Change rt6_probe to take a fib6_nh"), the logic changed to
> return if there is fib_nh_gw_family.
>
> Fixes: cc3a86c802f0 ("ipv6: Change rt6_probe to take a fib6_nh")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-20 20:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-20 7:39 [PATCH net] ipv6/route: return if there is no fib_nh_gw_family Hangbin Liu
2019-11-20 15:04 ` David Ahern
2019-11-20 20:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).