From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C9DC43141 for ; Wed, 20 Nov 2019 09:01:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C5EC2243F for ; Wed, 20 Nov 2019 09:01:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H1Xjbr1+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728068AbfKTJAQ (ORCPT ); Wed, 20 Nov 2019 04:00:16 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:51844 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728030AbfKTJAP (ORCPT ); Wed, 20 Nov 2019 04:00:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574240414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=df2jZGkaKYIX8XGP45379iKP8na141nKrPLZMKk0bUg=; b=H1Xjbr1+ST8mqdPBZ7xS0FuuCn5JHZSQ2FuYgEJnRqNHdR6ppijrRG8jdRsHKGOzwS49el TsJZDzYde6dupkbLSuoFQJnC/V0uhWuMY0DJ8FXF3o3pAcsAUMDjFx5XW7pXV/gUJqOIxh MP2OaPwp3bupCfUbUxtwelZyz3jiL0c= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-VJLFytE7NWGYW1toqlHtvw-1; Wed, 20 Nov 2019 04:00:13 -0500 Received: by mail-wm1-f71.google.com with SMTP id l184so4757068wmf.6 for ; Wed, 20 Nov 2019 01:00:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z+y/mrfI8ftCAoV6iK00SrByVRSNZiEo0o81DOjJrmQ=; b=tYpXMasNxYtR6eHXoYibjHZFRRCLdPPC/RlTG4xV3NZoB0whR6G5icm2IsN2vQUDhV zTPSZVNB5Xgw0X2jYknW87nijWetXR12MAtKFrzDHrEzholok/Y/l7LhupB9BQSkly9c V7b8MFeTQJ4F4l9uOwcv6g5o8d/rLysyiJWIGUiY3Gf8wAQOCN2t/bh96uEp9obAFJIm 1YRQoMmm/J5jKecMKJGt5N0iWnHAG8Dp4rAQDWP6SKxLZ1+Uq0RLbteypm2ebUEbD7Go mlmcaJc2r5fkXngLUS4mkNeADgtmoTsWYUqQya+w4GBvf/4HoDJsTY6DPYcmAJpyeiux dHPQ== X-Gm-Message-State: APjAAAUyWbAsoo9qMNXpPQlWLZW0nxUmwLXpXNmuW30I00bIGPBP6xa0 kjJOQ9Yilbmq37Nfwa/fQsL3zIvK9sE3E2Secpbj/3uW5ScX2wACpDaTnQcEKd27msl5baaEoNQ sPg7pZAvM9O+fRwmV X-Received: by 2002:a5d:640b:: with SMTP id z11mr1744247wru.195.1574240412214; Wed, 20 Nov 2019 01:00:12 -0800 (PST) X-Google-Smtp-Source: APXvYqzH0Kdjailo9KhJjoLt6nJgWn1k9d4qaEv02JFRBV4exDlOdZ6AoQZwxtxq6bSHolNraKXzJA== X-Received: by 2002:a5d:640b:: with SMTP id z11mr1744217wru.195.1574240411959; Wed, 20 Nov 2019 01:00:11 -0800 (PST) Received: from steredhat (a-nu5-32.tin.it. [212.216.181.31]) by smtp.gmail.com with ESMTPSA id m16sm5646172wml.47.2019.11.20.01.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2019 01:00:11 -0800 (PST) Date: Wed, 20 Nov 2019 10:00:08 +0100 From: Stefano Garzarella To: David Miller Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, decui@microsoft.com, stefanha@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jhansen@vmware.com Subject: Re: [PATCH net-next 4/6] vsock: add vsock_loopback transport Message-ID: <20191120090008.qlfc3lnzwl6yudsf@steredhat> References: <20191119110121.14480-1-sgarzare@redhat.com> <20191119110121.14480-5-sgarzare@redhat.com> <20191119.171501.666690660172999834.davem@davemloft.net> MIME-Version: 1.0 In-Reply-To: <20191119.171501.666690660172999834.davem@davemloft.net> X-MC-Unique: VJLFytE7NWGYW1toqlHtvw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 19, 2019 at 05:15:01PM -0800, David Miller wrote: > From: Stefano Garzarella > Date: Tue, 19 Nov 2019 12:01:19 +0100 >=20 > > +static int vsock_loopback_cancel_pkt(struct vsock_sock *vsk) > > +{ > > +=09struct vsock_loopback *vsock; > > +=09struct virtio_vsock_pkt *pkt, *n; > > +=09int ret; > > +=09LIST_HEAD(freeme); >=20 > Reverse christmas tree ordering of local variables here please. >=20 Sure, I'll fix in the v2. Thanks, Stefano