From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
brouer@redhat.com
Subject: Re: [PATCH net-next V3 0/3] page_pool: API for numa node change handling
Date: Wed, 20 Nov 2019 13:15:12 +0100 [thread overview]
Message-ID: <20191120131512.65e38054@carbon> (raw)
In-Reply-To: <20191120001456.11170-1-saeedm@mellanox.com>
On Wed, 20 Nov 2019 00:15:14 +0000
Saeed Mahameed <saeedm@mellanox.com> wrote:
> Performance analysis and conclusions by Jesper [1]:
> Impact on XDP drop x86_64 is inconclusive and shows only 0.3459ns
> slow-down, as this is below measurement accuracy of system.
Yes, I have had time to micro-benchmark this (on Intel), and given I
cannot demonstrate statistically significant slowdown, I'm going to
accept this change to the fast-path of page_pool.
For series:
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
(I'm going to ack each patch, in-order to make patchwork pickup the
ACK, and hopefully make this easier for DaveM).
> v2->v3:
> - Rebase on top of latest net-next and Jesper's page pool object
> release patchset [2]
> - No code changes
> - Performance analysis by Jesper added to the cover letter.
>
> v1->v2:
> - Drop last patch, as requested by Ilias and Jesper.
> - Fix documentation's performance numbers order.
>
> [1] https://github.com/xdp-project/xdp-project/blob/master/areas/mem/page_pool04_inflight_changes.org#performance-notes
> [2] https://patchwork.ozlabs.org/cover/1192098/
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-11-20 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:15 [PATCH net-next V3 0/3] page_pool: API for numa node change handling Saeed Mahameed
2019-11-20 0:15 ` [PATCH net-next V3 1/3] page_pool: Add API to update numa node Saeed Mahameed
2019-11-20 12:15 ` Jesper Dangaard Brouer
2019-11-20 0:15 ` [PATCH net-next V3 2/3] page_pool: Don't recycle non-reusable pages Saeed Mahameed
2019-11-20 12:16 ` Jesper Dangaard Brouer
2019-11-20 0:15 ` [PATCH net-next V3 3/3] net/mlx5e: Rx, Update page pool numa node when changed Saeed Mahameed
2019-11-20 12:16 ` Jesper Dangaard Brouer
2019-11-20 12:15 ` Jesper Dangaard Brouer [this message]
2019-11-20 19:48 ` [PATCH net-next V3 0/3] page_pool: API for numa node change handling David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120131512.65e38054@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).