From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264DBC432C0 for ; Wed, 20 Nov 2019 12:15:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5C11224F3 for ; Wed, 20 Nov 2019 12:15:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D2ObYBJM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729650AbfKTMPu (ORCPT ); Wed, 20 Nov 2019 07:15:50 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:52198 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728251AbfKTMPt (ORCPT ); Wed, 20 Nov 2019 07:15:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574252148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKnRYcmNL8BJ1ug3MK+Wuum2nKK0BHEptu0V4+b6Ml0=; b=D2ObYBJMf8q5pjzX2L0xa7+KzWRL9z2iVA8AJ+U+HM7/Hin74OnSjL6kmztPQOW23y/Pxt FcYaDww2CeAUzbPJwDbkaGerg31SClFoQItEyoeO4pq00QHv1xou9+xGlrTvy+9hsR1j7V RluMNLDDOG6U7IO8H/XaQpU3gbdaVd0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131-Nnr_LN0bN1uhlV3AfYj6lg-1; Wed, 20 Nov 2019 07:15:45 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E8FFD1883522; Wed, 20 Nov 2019 12:15:43 +0000 (UTC) Received: from carbon (ovpn-200-17.brq.redhat.com [10.40.200.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2884F66D5C; Wed, 20 Nov 2019 12:15:38 +0000 (UTC) Date: Wed, 20 Nov 2019 13:15:37 +0100 From: Jesper Dangaard Brouer To: Saeed Mahameed Cc: "David S. Miller" , "netdev@vger.kernel.org" , Jonathan Lemon , Ilias Apalodimas , brouer@redhat.com Subject: Re: [PATCH net-next V3 1/3] page_pool: Add API to update numa node Message-ID: <20191120131537.5481402e@carbon> In-Reply-To: <20191120001456.11170-2-saeedm@mellanox.com> References: <20191120001456.11170-1-saeedm@mellanox.com> <20191120001456.11170-2-saeedm@mellanox.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: Nnr_LN0bN1uhlV3AfYj6lg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 20 Nov 2019 00:15:17 +0000 Saeed Mahameed wrote: > Add page_pool_update_nid() to be called by page pool consumers when they > detect numa node changes. >=20 > It will update the page pool nid value to start allocating from the new > effective numa node. >=20 > This is to mitigate page pool allocating pages from a wrong numa node, > where the pool was originally allocated, and holding on to pages that > belong to a different numa node, which causes performance degradation. >=20 > For pages that are already being consumed and could be returned to the > pool by the consumer, in next patch we will add a check per page to avoid > recycling them back to the pool and return them to the page allocator. >=20 > Signed-off-by: Saeed Mahameed > Acked-by: Jonathan Lemon > Reviewed-by: Ilias Apalodimas Acked-by: Jesper Dangaard Brouer --=20 Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer