From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, davem@davemloft.net,
lorenzo.bianconi@redhat.com, mcroce@redhat.com,
jonathan.lemon@gmail.com
Subject: Re: [PATCH v5 net-next 0/3] add DMA-sync-for-device capability to page_pool API
Date: Wed, 20 Nov 2019 20:05:12 +0200 [thread overview]
Message-ID: <20191120180512.GB26040@apalos.home> (raw)
In-Reply-To: <20191120154522.GC21993@localhost.localdomain>
On Wed, Nov 20, 2019 at 05:45:22PM +0200, Lorenzo Bianconi wrote:
> > On Wed, 20 Nov 2019 16:54:16 +0200
> > Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >
> > > Do not change naming convention for the moment since the changes will
> > > hit other drivers as well. I will address it in another series.
> >
> > Yes, I agree, as I also said over IRC (freenode #xdp).
> >
> > The length (dma_sync_size) API addition to __page_pool_put_page() is
> > for now confined to this driver (mvneta). We can postpone the API-name
> > discussion, as you have promised here (and on IRC) that you will
> > "address it in another series". (Guess, given timing, the followup
> > series and discussion will happen after the merge window...)
>
> Right, I will work on it after next merging window.
As we discussed we can go a step further as page_pool_put_page() and
page_pool_recycle_direct() can probably go away. Syncing with the len make more
sense as long. As we document the 'allow_direct' flag sufficiently we can just
rename __page_pool_put_page -> page_pool_put_page and keep one function only.
In any case this patchset is fine for this merge window
for the series
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
next prev parent reply other threads:[~2019-11-20 18:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 14:54 [PATCH v5 net-next 0/3] add DMA-sync-for-device capability to page_pool API Lorenzo Bianconi
2019-11-20 14:54 ` [PATCH v5 net-next 1/3] net: mvneta: rely on page_pool_recycle_direct in mvneta_run_xdp Lorenzo Bianconi
2019-11-20 15:45 ` Jesper Dangaard Brouer
2019-11-20 14:54 ` [PATCH v5 net-next 2/3] net: page_pool: add the possibility to sync DMA memory for device Lorenzo Bianconi
2019-11-20 17:49 ` Jesper Dangaard Brouer
2019-11-20 18:00 ` Ilias Apalodimas
2019-11-20 18:42 ` Jonathan Lemon
2019-11-20 19:04 ` Jesper Dangaard Brouer
2019-11-20 14:54 ` [PATCH v5 net-next 3/3] net: mvneta: get rid of huge dma sync in mvneta_rx_refill Lorenzo Bianconi
2019-11-20 17:49 ` Jesper Dangaard Brouer
2019-11-20 15:37 ` [PATCH v5 net-next 0/3] add DMA-sync-for-device capability to page_pool API Jesper Dangaard Brouer
2019-11-20 15:45 ` Lorenzo Bianconi
2019-11-20 18:05 ` Ilias Apalodimas [this message]
2019-11-20 20:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120180512.GB26040@apalos.home \
--to=ilias.apalodimas@linaro.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=jonathan.lemon@gmail.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).