From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FBAFC432C3 for ; Thu, 21 Nov 2019 00:03:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D85820895 for ; Thu, 21 Nov 2019 00:03:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="afgWjA27" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbfKUADk (ORCPT ); Wed, 20 Nov 2019 19:03:40 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:47876 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726500AbfKUADk (ORCPT ); Wed, 20 Nov 2019 19:03:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5xmY3KMEdFXw13IZCuV7CTm19KFPphSqHIt2Exu3kpE=; b=afgWjA27czC+H19yptFCCc4nU Y4DdCmE6Xgj9H+SDsfUUr8QOYt+5arB3Ve+t0rGXVzP/by7/VOSZIJAmod+YvBtSgooHea9brA4fi E5wyocxPh7wtgxXIKpVWnMQ6axxXLde1JnVjf/GCe2M4uaGnAHlT8Lwnd01S87cjqDEBrdvXjoZbP qs23ZvR/4DmwMC8z0QCp6kHSDbzkVjexcBhNMn1kbj10uAjEER9wbxmFwIYJPfsYUfgrFXsGKv+8d 7vY1ublaHoP7EfpRKAiBrXBtPBwYW1yYzJu+/UORXWU9FjqmfdBoOcVRumnVg9Vx/LmJRuboL7FMh 3ejyG6Nxg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42408) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iXZwZ-00031o-Qw; Thu, 21 Nov 2019 00:03:31 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iXZwW-0002Am-Sb; Thu, 21 Nov 2019 00:03:28 +0000 Date: Thu, 21 Nov 2019 00:03:28 +0000 From: Russell King - ARM Linux admin To: Jakub Kicinski Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: sfp: add some quirks for GPON modules Message-ID: <20191121000328.GX25745@shell.armlinux.org.uk> References: <20191120113900.GP25745@shell.armlinux.org.uk> <20191120144632.0658d920@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191120144632.0658d920@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 20, 2019 at 02:46:32PM -0800, Jakub Kicinski wrote: > On Wed, 20 Nov 2019 11:42:47 +0000, Russell King wrote: > > static const struct sfp_quirk sfp_quirks[] = { > > + { > > + // Alcatel Lucent G-010S-P can operate at 2500base-X, but > > + // incorrectly report 2500MBd NRZ in their EEPROM > > + .vendor = "ALCATELLUCENT", > > + .part = "G010SP", > > + .modes = sfp_quirk_2500basex, > > + }, { > > + // Alcatel Lucent G-010S-A can operate at 2500base-X, but > > + // report 3.2GBd NRZ in their EEPROM > > + .vendor = "ALCATELLUCENT", > > + .part = "3FE46541AA", > > + .modes = sfp_quirk_2500basex, > > + }, { > > + // Huawei MA5671A can operate at 2500base-X, but report 1.2GBd > > + // NRZ in their EEPROM > > + .vendor = "HUAWEI", > > + .part = "MA5671A", > > + .modes = sfp_quirk_2500basex, > > + }, > > }; > > nit: no C++ comment style? Did you read Linus' opinions on commentry style during the discussion over the SPDX tags? https://lkml.org/lkml/2017/11/2/715 https://lkml.org/lkml/2017/11/25/133 It seems that Linus has decided to prefer // over /* */ -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up