From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] Add rudimentary SFP module quirk support
Date: Thu, 21 Nov 2019 03:28:30 +0100 [thread overview]
Message-ID: <20191121022830.GH18325@lunn.ch> (raw)
In-Reply-To: <20191120113900.GP25745@shell.armlinux.org.uk>
On Wed, Nov 20, 2019 at 11:39:00AM +0000, Russell King - ARM Linux admin wrote:
> The SFP module EEPROM describes the capabilities of the module, but
> doesn't describe the host interface. We have a certain amount of
> guess-work to work out how to configure the host - which works most
> of the time.
>
> However, there are some (such as GPON) modules which are able to
> support different host interfaces, such as 1000BASE-X and 2500BASE-X.
> The module will switch between each mode until it achieves link with
> the host.
>
> There is no defined way to describe this in the SFP EEPROM, so we can
> only recognise the module and handle it appropriately. This series
> adds the necessary recognition of the modules using a quirk system,
> and tweaks the support mask to allow them to link with the host at
> 2500BASE-X, thereby allowing the user to achieve full line rate.
Hi Russell
Did you consider making the Cotsworks checksum issue a quirk?
Andrew
next prev parent reply other threads:[~2019-11-21 2:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 11:39 [PATCH net-next 0/2] Add rudimentary SFP module quirk support Russell King - ARM Linux admin
2019-11-20 11:42 ` [PATCH net-next 1/2] net: sfp: add support for module quirks Russell King
2019-11-21 2:24 ` Andrew Lunn
2019-11-21 9:11 ` Russell King - ARM Linux admin
2019-11-21 3:46 ` Florian Fainelli
2019-11-20 11:42 ` [PATCH net-next 2/2] net: sfp: add some quirks for GPON modules Russell King
2019-11-20 22:46 ` Jakub Kicinski
2019-11-21 0:03 ` Russell King - ARM Linux admin
2019-11-21 0:14 ` Jakub Kicinski
2019-11-21 2:26 ` Andrew Lunn
2019-11-21 3:46 ` Florian Fainelli
2019-11-21 2:28 ` Andrew Lunn [this message]
2019-11-21 6:29 ` [PATCH net-next 0/2] Add rudimentary SFP module quirk support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121022830.GH18325@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).