From: Daniel Borkmann <daniel@iogearbox.net>
To: Quentin Monnet <quentin.monnet@netronome.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
oss-drivers@netronome.com, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH bpf-next] tools: bpf: fix build for 'make -s tools/bpf O=<dir>'
Date: Thu, 21 Nov 2019 09:52:32 +0100 [thread overview]
Message-ID: <20191121085232.GC31576@pc-11.home> (raw)
In-Reply-To: <20191119105626.21453-1-quentin.monnet@netronome.com>
On Tue, Nov 19, 2019 at 10:56:26AM +0000, Quentin Monnet wrote:
> Building selftests with 'make TARGETS=bpf kselftest' was fixed in commit
> 55d554f5d140 ("tools: bpf: Use !building_out_of_srctree to determine
> srctree"). However, by updating $(srctree) in tools/bpf/Makefile for
> in-tree builds only, we leave out the case where we pass an output
> directory to build BPF tools, but $(srctree) is not set. This
> typically happens for:
>
> $ make -s tools/bpf O=/tmp/foo
> Makefile:40: /tools/build/Makefile.feature: No such file or directory
>
> Fix it by updating $(srctree) in the Makefile not only for out-of-tree
> builds, but also if $(srctree) is empty.
>
> Detected with test_bpftool_build.sh.
>
> Fixes: 55d554f5d140 ("tools: bpf: Use !building_out_of_srctree to determine srctree")
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied, thanks!
prev parent reply other threads:[~2019-11-21 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 10:56 [PATCH bpf-next] tools: bpf: fix build for 'make -s tools/bpf O=<dir>' Quentin Monnet
2019-11-21 8:52 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121085232.GC31576@pc-11.home \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).