From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92945C432C0 for ; Thu, 21 Nov 2019 09:11:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23C432071C for ; Thu, 21 Nov 2019 09:11:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="HZn/Zk7B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726351AbfKUJL2 (ORCPT ); Thu, 21 Nov 2019 04:11:28 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:54004 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfKUJL2 (ORCPT ); Thu, 21 Nov 2019 04:11:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2m8sHqxbMuus5FLhodLrWPaA0QvExavFaEJfRF0MuCg=; b=HZn/Zk7BPxTNkgGTln9E/zbp9 8N/z2atvyAJ7k0ZRfll3u8QcN+D84n6MeULGjNBLBWvAK7ivYvZchezg3cEigqjXvuT5YBhZj3S/W S6YB13gHLLhpFNhNmWOIyfsH4uqwgxh571TdwjAO10ORg6XcXIT/wokXR5aprZkm/g7+dmiV8XxQV fE/4IgMC1YjwNHFwJxfkPieGbwroVH5ZgNhtNaxFqJNd9ngX5hilE7cZCtGtH2+QTNZH8sMbMMDS9 U8cglrKgImSp2uffcF7soSbSrP+THudjxE9RTLjupSc/xf6O+G3BMcda53lAlYxTyASYVNlURPqA9 PiPwFZt5A==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:59152) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iXiUi-0005hb-Ld; Thu, 21 Nov 2019 09:11:20 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iXiUf-0002cL-PO; Thu, 21 Nov 2019 09:11:17 +0000 Date: Thu, 21 Nov 2019 09:11:17 +0000 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: sfp: add support for module quirks Message-ID: <20191121091117.GY25745@shell.armlinux.org.uk> References: <20191120113900.GP25745@shell.armlinux.org.uk> <20191121022452.GF18325@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121022452.GF18325@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Nov 21, 2019 at 03:24:52AM +0100, Andrew Lunn wrote: > > +static size_t sfp_strlen(const char *str, size_t maxlen) > > +{ > > + size_t size, i; > > + > > + /* Trailing characters should be filled with space chars */ > > + for (i = 0, size = 0; i < maxlen; i++) > > + if (str[i] != ' ') > > + size = i + 1; > > Hi Russell > > Is this space padding part of the standard? What's the bet there are > some with a NULL character? Yes, it's specified. I haven't yet seen a module not space-pad. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up