From: Greg KH <gregkh@linuxfoundation.org>
To: "Toke Høiland-Jørgensen" <thoiland@redhat.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH RFC net-next] net: WireGuard secure network tunnel
Date: Thu, 21 Nov 2019 12:50:13 +0100 [thread overview]
Message-ID: <20191121115013.GA427938@kroah.com> (raw)
In-Reply-To: <877e3t8qv7.fsf@toke.dk>
On Thu, Nov 21, 2019 at 11:29:16AM +0100, Toke Høiland-Jørgensen wrote:
> "Jason A. Donenfeld" <Jason@zx2c4.com> writes:
>
> > RFC Note:
> > This is a RFC for folks who want to play with this early, because
> > Herbert's cryptodev-2.6 tree hasn't yet made it into net-next. I'll
> > repost this as a v1 (possibly with feedback incorporated) once the
> > various trees are in the right place. This compiles on top of the
> > Frankenzinc patchset from Ard, though it hasn't yet received suitable
> > testing there for me to call it v1 just yet. Preliminary testing with
> > the usual netns.sh test suite on x86 indicates it's at least mostly
> > functional, but I'll be giving things further scrutiny in the days to
> > come.
>
> Hi Jason
>
> Great to see this! Just a few small comments for now:
>
> > +/*
> > + * Copyright (C) 2015-2019 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
> > + */
>
> Could you please get rid of the "All Rights Reserved" (here, and
> everywhere else)? All rights are *not* reserved: this is licensed under
> the GPL. Besides, that phrase is in general dubious at best:
> https://en.wikipedia.org/wiki/All_rights_reserved
Don't take legal questions/advice on a developer mailing list :)
This text is fine as-is, please consult your RedHat lawyers for why that
is so.
And if RedHat does have issues with this, have them please clean up the
instances in the kernel where they have this same text before asking
anyone else to do so.
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-21 11:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 20:35 [PATCH RFC net-next] net: WireGuard secure network tunnel Jason A. Donenfeld
2019-11-21 10:29 ` Toke Høiland-Jørgensen
2019-11-21 11:07 ` Jason A. Donenfeld
2019-11-21 12:00 ` Toke Høiland-Jørgensen
2019-11-21 14:44 ` Miguel Ojeda
2019-11-21 15:26 ` Jason A. Donenfeld
2019-11-21 11:50 ` Greg KH [this message]
2019-11-27 10:49 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121115013.GA427938@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thoiland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).