From: "Daniel Walker (danielwa)" <danielwa@cisco.com>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] gianfar: Don't force RGMII mode after reset, use defaults
Date: Thu, 21 Nov 2019 15:58:31 +0000 [thread overview]
Message-ID: <20191121155830.GC18744@zorba> (raw)
In-Reply-To: <1573570511-32651-1-git-send-email-claudiu.manoil@nxp.com>
On Tue, Nov 12, 2019 at 04:55:11PM +0200, Claudiu Manoil wrote:
> We received reports that forcing the MAC into RGMII (1 Gbps)
> interface mode after MAC reset occasionally disrupts operation
> of PHYs capable only of 100Mbps, even after adjust_link kicks
> in and re-adjusts the interface mode in MACCFG2 accordingly.
> Instead of forcing MACCFG2 into RGMII mode, let's use the default
> reset value of MACCFG2 (that leaves the IF_Mode field unset) and
> let adjust_link configure the correct mode from the beginning.
> MACCFG2_INIT_SETTINGS is dropped, only the PAD_CRC bit is preserved,
> the remaining fields (IF_Mode and Duplex) are left for adjust_link.
> Tested on boards with gigabit PHYs.
>
> MACCFG2_INIT_SETTINGS is there since day one, but the issue
> got visible after introducing the MAC reset and reconfig support,
> which added MAC reset at runtime, at interface open.
>
> Fixes: a328ac92d314 ("gianfar: Implement MAC reset and reconfig procedure")
>
We tested these changes on our side, and it appears to solve the problem.
Have been able to resolve the issues which you have seen on your side?
Daniel
prev parent reply other threads:[~2019-11-21 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:55 [PATCH net] gianfar: Don't force RGMII mode after reset, use defaults Claudiu Manoil
2019-11-12 16:47 ` Daniel Walker
2019-11-12 16:55 ` HEMANT RAMDASI (hramdasi)
2019-11-12 17:09 ` Claudiu Manoil
2019-11-12 17:28 ` HEMANT RAMDASI (hramdasi)
2019-11-13 14:00 ` Claudiu Manoil
2019-11-13 14:21 ` HEMANT RAMDASI (hramdasi)
2019-11-13 16:01 ` Claudiu Manoil
2020-02-19 18:57 ` Daniel Walker (danielwa)
2020-02-20 11:42 ` Claudiu Manoil
2019-11-21 15:58 ` Daniel Walker (danielwa) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121155830.GC18744@zorba \
--to=danielwa@cisco.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).