From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2] net: sfp: soft status and control support
Date: Thu, 21 Nov 2019 16:23:09 +0000 [thread overview]
Message-ID: <20191121162309.GZ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <DB6PR0402MB27891CA467D04389FA68B0CFE04E0@DB6PR0402MB2789.eurprd04.prod.outlook.com>
On Thu, Nov 21, 2019 at 03:51:07PM +0000, Ioana Ciornei wrote:
> > Subject: [PATCH net-next v2] net: sfp: soft status and control support
> >
> > Add support for the soft status and control register, which allows TX_FAULT
> > and RX_LOS to be monitored and TX_DISABLE to be set. We make use of this
> > when the board does not support GPIOs for these signals.
>
> Hi Russell,
>
> With this addition, shouldn't the following print be removed?
>
> [ 2.967583] sfp sfp-mac4: No tx_disable pin: SFP modules will always be emitting.
No, because modules do not have to provide the soft controls.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-11-21 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 12:29 [PATCH net-next v2] net: sfp: soft status and control support Russell King
2019-11-21 2:36 ` Andrew Lunn
2019-11-21 4:00 ` Florian Fainelli
2019-11-21 6:29 ` David Miller
2019-11-21 15:51 ` Ioana Ciornei
2019-11-21 16:21 ` Andrew Lunn
2019-11-21 18:24 ` Ioana Ciornei
2019-11-21 16:23 ` Russell King - ARM Linux admin [this message]
2019-11-21 18:33 ` Ioana Ciornei
2019-11-21 18:54 ` Russell King - ARM Linux admin
2019-11-21 19:14 ` Ioana Ciornei
2019-11-21 23:17 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121162309.GZ25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).