From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F66C432C0 for ; Fri, 22 Nov 2019 00:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BBCA206D8 for ; Fri, 22 Nov 2019 00:27:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="z7UmRhEU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726634AbfKVA1b (ORCPT ); Thu, 21 Nov 2019 19:27:31 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:36182 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfKVA1a (ORCPT ); Thu, 21 Nov 2019 19:27:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QIJZTLKonnK0A0lxCHwgs5Dx3L4fEmo9nQtqXEl/IYQ=; b=z7UmRhEUyufGxXPwPUozRUy1l c7YYsmCtZYh74sxsFUGvhcDftxSFYMPQ4xrNkEF1tpjBEHUHWfyOZExWh9ncrHUYj3DF8a2GNd4ih jiFF6e7J8x73yVBygZxC2ndX/8jwA71CTp5ZfSbeHcVuaA7uF5h4xu9iNl6JwM/hl8pYoEafiVA4X Mf8jXBoPUA4EoYE6c6GksU8AylU4eumyZ56uCLTfSimdVJ5qbhrw02DByts2XzL1OAxv9NmrD0oE6 tShTU2H/Rp8eli1rCFnGD3oo+Q5op9aKUZ+vW8Irj4HA6FgJKyylpMPLr+tUFVBp4Sq76AYJ2djrp Y38MQyddg==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:38744) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iXwnG-0001cU-0w; Fri, 22 Nov 2019 00:27:26 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iXwnD-0003CA-5M; Fri, 22 Nov 2019 00:27:23 +0000 Date: Fri, 22 Nov 2019 00:27:23 +0000 From: Russell King - ARM Linux admin To: Ioana Ciornei Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch Subject: Re: [PATCH net-next 2/3] dpaa2-eth: add phylink_mac_ops stub callbacks Message-ID: <20191122002723.GE25745@shell.armlinux.org.uk> References: <1574363727-5437-1-git-send-email-ioana.ciornei@nxp.com> <1574363727-5437-3-git-send-email-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1574363727-5437-3-git-send-email-ioana.ciornei@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Nov 21, 2019 at 09:15:26PM +0200, Ioana Ciornei wrote: > For the moment, we do not have a way to query the PCS link state > or to restart aneg on it. Add stub functions for both of the callbacks > since phylink can provoke an oops when an SFP module has been inserted. > > Fixes: 719479230893 ("dpaa2-eth: add MAC/PHY support through phylink") > Reported-by: Russell King > Signed-off-by: Ioana Ciornei This is independent of patch 1. Acked-by: Russell King > --- > drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > index 0200308d1bc7..efc587515661 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > @@ -183,11 +183,24 @@ static void dpaa2_mac_link_down(struct phylink_config *config, > netdev_err(mac->net_dev, "dpmac_set_link_state() = %d\n", err); > } > > +static void dpaa2_mac_an_restart(struct phylink_config *config) > +{ > + /* Not supported */ > +} > + > +static void dpaa2_mac_pcs_get_state(struct phylink_config *config, > + struct phylink_link_state *state) > +{ > + /* Not supported */ > +} > + > static const struct phylink_mac_ops dpaa2_mac_phylink_ops = { > .validate = dpaa2_mac_validate, > .mac_config = dpaa2_mac_config, > .mac_link_up = dpaa2_mac_link_up, > .mac_link_down = dpaa2_mac_link_down, > + .mac_an_restart = dpaa2_mac_an_restart, > + .mac_pcs_get_state = dpaa2_mac_pcs_get_state, > }; > > bool dpaa2_mac_is_type_fixed(struct fsl_mc_device *dpmac_dev, > -- > 1.9.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up