From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39FE4C432C0 for ; Fri, 22 Nov 2019 06:05:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0366A20674 for ; Fri, 22 Nov 2019 06:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574402709; bh=SeAsYV7SVBrdZa76EEz+x99Xd94q22fntAQUgeEiTRU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iCFH2dNhqKC1TPFqFVKOCXdMOIeGHw555Re7KTXvfIzt5P8TAWZEA3XlGkKKVWSoJ D5poW963KN7YlwjGLEjWi8ipoyTCbLqNkzZVW67Ay9fyOJU90kNpLEq94/ZG6195Eq Fg83IwRaDhrkI4LY6QyKQj/9iuZsU/K9WeNQnTDo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729248AbfKVGFI (ORCPT ); Fri, 22 Nov 2019 01:05:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:41530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728813AbfKVGCn (ORCPT ); Fri, 22 Nov 2019 01:02:43 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E32052068F; Fri, 22 Nov 2019 06:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574402562; bh=SeAsYV7SVBrdZa76EEz+x99Xd94q22fntAQUgeEiTRU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u+hStftTAnKvuFzZmE2EQqG1+7FkkEragbWtPHbTcHNjLtlXhsamH/Fj0qI9qiWmk o3ACMd9d4dWVCk1gwiSC3q3TS0a8dJoK/rQVetbSsrZ4EX/oma11kU+Ozu7YgcVV53 msxz7e3nzPCIzA4U3XU5dbcWNdrfoQRG6J5BC2Xg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wen Yang , Peng Hao , Zhao Qiang , "David S. Miller" , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sasha Levin Subject: [PATCH AUTOSEL 4.9 67/91] net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe() Date: Fri, 22 Nov 2019 01:01:05 -0500 Message-Id: <20191122060129.4239-66-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122060129.4239-1-sashal@kernel.org> References: <20191122060129.4239-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wen Yang [ Upstream commit 40752b3eae29f8ca2378e978a02bd6dbeeb06d16 ] This patch fixes potential double frees if register_hdlc_device() fails. Signed-off-by: Wen Yang Reviewed-by: Peng Hao CC: Zhao Qiang CC: "David S. Miller" CC: netdev@vger.kernel.org CC: linuxppc-dev@lists.ozlabs.org CC: linux-kernel@vger.kernel.org Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/wan/fsl_ucc_hdlc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 7a62316c570d2..b2c1e872d5ed5 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c @@ -1117,7 +1117,6 @@ static int ucc_hdlc_probe(struct platform_device *pdev) if (register_hdlc_device(dev)) { ret = -ENOBUFS; pr_err("ucc_hdlc: unable to register hdlc device\n"); - free_netdev(dev); goto free_dev; } -- 2.20.1