From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-can@vger.kernel.org,
kernel@pengutronix.de, Pankaj Sharma <pankj.sharma@samsung.com>,
Sriram Dash <sriram.dash@samsung.com>,
Dan Murphy <dmurphy@ti.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH 2/2] can: m_can_platform: remove unnecessary m_can_class_resume() call
Date: Fri, 22 Nov 2019 15:52:51 +0100 [thread overview]
Message-ID: <20191122145251.9775-3-mkl@pengutronix.de> (raw)
In-Reply-To: <20191122145251.9775-1-mkl@pengutronix.de>
From: Pankaj Sharma <pankj.sharma@samsung.com>
The function m_can_runtime_resume() is getting recursively called from
m_can_class_resume(). This results in a lock up.
We need not call m_can_class_resume() during m_can_runtime_resume().
Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework")
Signed-off-by: Pankaj Sharma <pankj.sharma@samsung.com>
Signed-off-by: Sriram Dash <sriram.dash@samsung.com>
Acked-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/m_can/m_can_platform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
index 2eaa3543d233..38ea5e600fb8 100644
--- a/drivers/net/can/m_can/m_can_platform.c
+++ b/drivers/net/can/m_can/m_can_platform.c
@@ -166,8 +166,6 @@ static int __maybe_unused m_can_runtime_resume(struct device *dev)
if (err)
clk_disable_unprepare(mcan_class->hclk);
- m_can_class_resume(dev);
-
return err;
}
--
2.24.0
next prev parent reply other threads:[~2019-11-22 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 14:52 pull-request: can 2019-11-22 Marc Kleine-Budde
2019-11-22 14:52 ` [PATCH 1/2] can: m_can_platform: set net_device structure as driver data Marc Kleine-Budde
2019-11-22 14:52 ` Marc Kleine-Budde [this message]
2019-11-22 17:42 ` pull-request: can 2019-11-22 David Miller
[not found] <CGME20191119102201epcas5p4e215c25d5d07269a7afb1f86fac0be65@epcas5p4.samsung.com>
2019-11-19 10:20 ` [PATCH 0/2] can: m_can_platform: Bug fix of kernel panic for Pankaj Sharma
2019-11-19 10:20 ` [PATCH 2/2] can: m_can_platform: remove unnecessary m_can_class_resume() call Pankaj Sharma
2019-11-19 14:45 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122145251.9775-3-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pankj.sharma@samsung.com \
--cc=sriram.dash@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).