From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8413BC43215 for ; Fri, 22 Nov 2019 19:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E8992070E for ; Fri, 22 Nov 2019 19:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574452332; bh=+P2nX06dAGulJqQcn7qVK/Higgjr+iMrFKm6gdTyc2U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=stRRfp3xOB/NXIKu7gDtno7/PtzkB4bf/eaX3qJLxOGBAj/YXfJ1OyyTAJrK6kxrH ZIlwsBSvN43Lf83lqLZuu42MH5B9pCZeubn+Xp9X6aPuMLpDc6fHSj0M2RbNWAlkZ7 b0Ti1KdjRjZUNBRVLPoaxGEU+su8w04OSO++SLqU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbfKVTtz (ORCPT ); Fri, 22 Nov 2019 14:49:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:50134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727630AbfKVTtx (ORCPT ); Fri, 22 Nov 2019 14:49:53 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A28182072D; Fri, 22 Nov 2019 19:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574452192; bh=+P2nX06dAGulJqQcn7qVK/Higgjr+iMrFKm6gdTyc2U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zSp4/eC3hmU5SGm9qeY7mawyK0SGSfJDA7Yqz8mxZsm1zxbYraItgItc2kpaSH8MA 1b0em6vLjxU4RSxjH33NVCBU1XF+MRDT7BCGY09u3hguEYbqeIDLC1aFEc/RH31D+k IPSy44ZWVpyUw7H2qk7GEdd2fNp/2d+NqQ/Sjewg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Oliver Neukum , syzbot+a8d4acdad35e6bbca308@syzkaller.appspotmail.com, "David S . Miller" , Sasha Levin , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 17/21] ax88172a: fix information leak on short answers Date: Fri, 22 Nov 2019 14:49:27 -0500 Message-Id: <20191122194931.24732-17-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122194931.24732-1-sashal@kernel.org> References: <20191122194931.24732-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Oliver Neukum [ Upstream commit a9a51bd727d141a67b589f375fe69d0e54c4fe22 ] If a malicious device gives a short MAC it can elicit up to 5 bytes of leaked memory out of the driver. We need to check for ETH_ALEN instead. Reported-by: syzbot+a8d4acdad35e6bbca308@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/ax88172a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c index 501576f538546..914cac55a7ae7 100644 --- a/drivers/net/usb/ax88172a.c +++ b/drivers/net/usb/ax88172a.c @@ -208,7 +208,7 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf) /* Get the MAC address */ ret = asix_read_cmd(dev, AX_CMD_READ_NODE_ID, 0, 0, ETH_ALEN, buf, 0); - if (ret < 0) { + if (ret < ETH_ALEN) { netdev_err(dev->net, "Failed to read MAC address: %d\n", ret); goto free; } -- 2.20.1