[ipsec-next:testing 6/6] net/xfrm/espintcp.c:402:13: sparse: sparse: incompatible types in comparison expression (different address spaces):

[ipsec-next:testing 6/6] net/xfrm/espintcp.c:402:13: sparse: sparse: incompatible types in comparison expression (different address spaces):

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git testing
head:   73994d31bda7074698e8d07b40152eeabccd5780
commit: 73994d31bda7074698e8d07b40152eeabccd5780 [6/6] xfrm: add espintcp (RFC 8229)
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-36-g9305d48-dirty
        git checkout 73994d31bda7074698e8d07b40152eeabccd5780
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> net/xfrm/espintcp.c:402:13: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> net/xfrm/espintcp.c:402:13: sparse:    void [noderef] <asn:4> *
>> net/xfrm/espintcp.c:402:13: sparse:    void *

vim +402 net/xfrm/espintcp.c

   390	
   391	static int espintcp_init_sk(struct sock *sk)
   392	{
   393		struct inet_connection_sock *icsk = inet_csk(sk);
   394		struct strp_callbacks cb = {
   395			.rcv_msg = espintcp_rcv,
   396			.parse_msg = espintcp_parse,
   397		};
   398		struct espintcp_ctx *ctx;
   399		int err;
   400	
   401		/* sockmap is not compatible with espintcp */
 > 402		if (rcu_access_pointer(sk->sk_user_data))
   403			return -EBUSY;
   404	
   405		ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
   406		if (!ctx)
   407			return -ENOMEM;
   408	
   409		err = strp_init(&ctx->strp, sk, &cb);
   410		if (err)
   411			goto free;
   412	
   413		__sk_dst_reset(sk);
   414	
   415		strp_check_rcv(&ctx->strp);
   416		skb_queue_head_init(&ctx->ike_queue);
   417		skb_queue_head_init(&ctx->out_queue);
   418		sk->sk_prot = &espintcp_prot;
   419		sk->sk_socket->ops = &espintcp_ops;
   420		ctx->saved_data_ready = sk->sk_data_ready;
   421		ctx->saved_write_space = sk->sk_write_space;
   422		sk->sk_data_ready = espintcp_data_ready;
   423		sk->sk_write_space = espintcp_write_space;
   424		sk->sk_destruct = espintcp_destruct;
   425		rcu_assign_pointer(icsk->icsk_ulp_data, ctx);
   426		INIT_WORK(&ctx->work, espintcp_tx_work);
   427	
   428		/* avoid using task_frag */
   429		sk->sk_allocation = GFP_ATOMIC;
   430	
   431		return 0;
   432	
   433	free:
   434		kfree(ctx);
   435		return err;
   436	}
   437	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Re: [ipsec-next:testing 6/6] net/xfrm/espintcp.c:402:13: sparse: sparse: incompatible types in comparison expression (different address spaces):

[Steffen Klassert]

On Sat, Nov 23, 2019 at 10:53:27AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git testing
> head:   73994d31bda7074698e8d07b40152eeabccd5780
> commit: 73994d31bda7074698e8d07b40152eeabccd5780 [6/6] xfrm: add espintcp (RFC 8229)
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.1-36-g9305d48-dirty
>         git checkout 73994d31bda7074698e8d07b40152eeabccd5780
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> net/xfrm/espintcp.c:402:13: sparse: sparse: incompatible types in comparison expression (different address spaces):
> >> net/xfrm/espintcp.c:402:13: sparse:    void [noderef] <asn:4> *
> >> net/xfrm/espintcp.c:402:13: sparse:    void *

Sabrina, can you please fix this?