From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C936C432C0 for ; Mon, 25 Nov 2019 18:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E595A20748 for ; Mon, 25 Nov 2019 18:50:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727254AbfKYSuX convert rfc822-to-8bit (ORCPT ); Mon, 25 Nov 2019 13:50:23 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:52820 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfKYSuX (ORCPT ); Mon, 25 Nov 2019 13:50:23 -0500 Received: from localhost (c-73-35-209-67.hsd1.wa.comcast.net [73.35.209.67]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1FA8315008C8B; Mon, 25 Nov 2019 10:50:23 -0800 (PST) Date: Mon, 25 Nov 2019 10:50:22 -0800 (PST) Message-Id: <20191125.105022.2027962925589066709.davem@davemloft.net> To: zenczykowski@gmail.com Cc: maze@google.com, netdev@vger.kernel.org Subject: Re: [PATCH] net-sctp: replace some sock_net(sk) with just 'net' From: David Miller In-Reply-To: <20191124104727.8273-1-zenczykowski@gmail.com> References: <20191124104727.8273-1-zenczykowski@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-2 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Nov 2019 10:50:23 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maciej Żenczykowski Date: Sun, 24 Nov 2019 02:47:27 -0800 > @@ -8264,6 +8264,7 @@ static struct sctp_bind_bucket *sctp_bucket_create( > > static int sctp_get_port_local(struct sock *sk, union sctp_addr *addr) > { > + struct net *net = sock_net(sk); > struct sctp_sock *sp = sctp_sk(sk); > bool reuse = (sk->sk_reuse || sp->reuse); > struct sctp_bind_hashbucket *head; /* hash list */ Please don't make the reverse christmas tree situation here worse, thank you.