From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com, jbenc@redhat.com,
roopa@cumulusnetworks.com
Subject: Re: [PATCH net] ipv6: set lwtstate for ns and na dst
Date: Mon, 25 Nov 2019 14:53:36 -0800 (PST) [thread overview]
Message-ID: <20191125.145336.1803100409578989775.davem@davemloft.net> (raw)
In-Reply-To: <3743d1e2c7fc26fb5f7401b6b0956097e997c48c.1574662992.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 25 Nov 2019 14:23:12 +0800
> This patch is to fix an issue that ipv6 ns and na can't go out with the
> correct tunnel info, and it can be reproduced by:
And why shouldn't RS and redirects get this treatment too?
And then, at that point, all callers of ndisc_send_skb() have this
early route lookup code (and thus the "!dst" code path is unused), and
the question ultimately becomes why doesn't ndisc_send_skb() itself
have the dst lookup modification?
I'm not too sure about this change and will not apply it.
next prev parent reply other threads:[~2019-11-25 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 6:23 [PATCH net] ipv6: set lwtstate for ns and na dst Xin Long
2019-11-25 22:53 ` David Miller [this message]
2019-11-26 8:47 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125.145336.1803100409578989775.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jbenc@redhat.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).