From: Nishad Kamdar <nishadkamdar@gmail.com>
To: "Jakub Kicinski" <jakub.kicinski@netronome.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: Use the correct style for SPDX License Identifier
Date: Mon, 25 Nov 2019 20:09:10 +0530 [thread overview]
Message-ID: <20191125143900.GA2572@nishad> (raw)
In-Reply-To: <20191123183455.6266e9a8@cakuba.netronome.com>
On Sat, Nov 23, 2019 at 06:34:55PM -0800, Jakub Kicinski wrote:
> On Sat, 23 Nov 2019 18:38:19 +0530, Nishad Kamdar wrote:
> > diff --git a/drivers/net/phy/aquantia.h b/drivers/net/phy/aquantia.h
> > index 5a16caab7b2f..40e0be0f4e1c 100644
> > --- a/drivers/net/phy/aquantia.h
> > +++ b/drivers/net/phy/aquantia.h
> > @@ -1,5 +1,5 @@
> > -/* SPDX-License-Identifier: GPL-2.0
> > - * HWMON driver for Aquantia PHY
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/* HWMON driver for Aquantia PHY
>
> You're adding an extra space here. Is this intentional?
No, It shouldn't be there.
Thanks you for pointing it out.
I'll update and resend the patch.
Thanks for the review.
Regards,
Nishad
>
> > *
> > * Author: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> > * Author: Andrew Lunn <andrew@lunn.ch>
prev parent reply other threads:[~2019-11-25 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 13:08 [PATCH] net: phy: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-11-24 2:34 ` Jakub Kicinski
2019-11-25 14:39 ` Nishad Kamdar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125143900.GA2572@nishad \
--to=nishadkamdar@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).