From: David Miller <davem@davemloft.net>
To: oliver.peter.herms@gmail.com
Cc: yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: ip/tnl: Set iph->id only when don't fragment is not set
Date: Tue, 26 Nov 2019 12:51:56 -0800 (PST) [thread overview]
Message-ID: <20191126.125156.2138813710312929109.davem@davemloft.net> (raw)
In-Reply-To: <4e964168-2c83-24bb-8e44-f5f47555e589@gmail.com>
From: Oliver Herms <oliver.peter.herms@gmail.com>
Date: Tue, 26 Nov 2019 20:10:52 +0100
> Would you be willing to merge a patch that offers this?
No.
There is lots of precendence for incrementing the ID, look
at SLIP compression:
deltaS = ntohs(ip->id) - ntohs(cs->cs_ip.id);
if(deltaS != 1){
cp = encode(cp,deltaS);
changes |= NEW_I;
}
That's just one example, it won't compress unless the ID
field is (unconditionally) incrementing.
The RFC being discussed here is poorly constructed and is founded on a
false basis of reality. It's the usual tone deaf IETF stuff... and
Linux will not participate.
Thanks.
next prev parent reply other threads:[~2019-11-26 20:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 13:24 [PATCH v2] net: ip/tnl: Set iph->id only when don't fragment is not set Oliver Herms
2019-11-25 22:41 ` David Miller
2019-11-26 19:10 ` Oliver Herms
2019-11-26 20:51 ` David Miller [this message]
2019-11-26 22:45 ` Eric Dumazet
2019-11-26 23:32 ` Oliver Herms
2019-11-27 0:23 ` Eric Dumazet
2019-11-27 0:28 ` Eric Dumazet
2019-11-27 12:19 ` Oliver Herms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126.125156.2138813710312929109.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=oliver.peter.herms@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).