From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74EEC432C0 for ; Mon, 2 Dec 2019 21:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A33C62071F for ; Mon, 2 Dec 2019 21:49:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fomichev-me.20150623.gappssmtp.com header.i=@fomichev-me.20150623.gappssmtp.com header.b="hU3YnGcn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725939AbfLBVtj (ORCPT ); Mon, 2 Dec 2019 16:49:39 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39973 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbfLBVtj (ORCPT ); Mon, 2 Dec 2019 16:49:39 -0500 Received: by mail-pf1-f195.google.com with SMTP id q8so427719pfh.7 for ; Mon, 02 Dec 2019 13:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fomichev-me.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PH5rAfJlRyn8q19ji6GepRAzUZJM4EEqv75vjx7WGSA=; b=hU3YnGcnL1BVo0KJqYCg3Yz7tFUJr5beQ0w2GUAcsQdpyfM3EDlpyauMfH7rhTEkfU Zzt6+0QWgAVGvZS0vNgG+qORlxBtLCl5ft8lopJuxhF1iZEY7ilyv4Jbt3LkRXRLeJ6o +ceYBwLm3AlJi/xcclAH0i6hPlr198x8LIeqRuQuDJLgRwdqg1fT6HUr2b94lW4Cc6RU aQjfXJR1hDndevxaPIAeoCa+u5D0sQSR1KXNwMDR1tuLAUAH0wh2siZGg9DjpEjxKKKI W2UeoATvME5JyXDEqPdDYtimMQJ49/blJWvZN4jdcINgtKjb0j+V7kXBLUxKo3paHGot HrsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PH5rAfJlRyn8q19ji6GepRAzUZJM4EEqv75vjx7WGSA=; b=kgRYEMBV5QqViysSkUsKjPx7gsSBguZK9DYjuiuUUtQy+iboESJom+CA58tpizJONB ApD9zVrbEHgm92R0wonv9e6bwXScwQbWM/doGotyQ4Q1HycBkDrETHkzinj0jL6YivhD thcjuDo1lh0mZTcYwy/sGDGK2MCfjlk0klDjaJaaTPWdkLftsOpI2+Ua//OP3+jWlW+B NEtJ392C81EJXctHmuQsswHHCGBAX5+7B+0VgKPYazOTj6IukyGHq8is8EwONp1ycIXI WrZR+pELQgVYwqvEXz89DybOt2vrYdOqnoAWfRqJCS/krPZrcVjFjD0TNpzWPn4he0jA bxXQ== X-Gm-Message-State: APjAAAWWQq5wviSkbYvTjGQLlnYj+hCdESBNtMCq6/SN0Rdl07WpxNO7 epGMKbUgiMlJukGKTqczl9KHmA== X-Google-Smtp-Source: APXvYqw5EbKy+H8CM80uqfh4Fc2QYXwkiHSbrp8OChrZppo8ykLLO28b+mlbIWWQDKp2w+igvwxW0w== X-Received: by 2002:a65:6104:: with SMTP id z4mr1370359pgu.7.1575323378210; Mon, 02 Dec 2019 13:49:38 -0800 (PST) Received: from localhost ([2601:646:8f00:18d9:d0fa:7a4b:764f:de48]) by smtp.gmail.com with ESMTPSA id z19sm462794pfn.49.2019.12.02.13.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2019 13:49:37 -0800 (PST) Date: Mon, 2 Dec 2019 13:49:35 -0800 From: Stanislav Fomichev To: Andrii Nakryiko Cc: Stanislav Fomichev , Networking , bpf , "David S. Miller" , Alexei Starovoitov , Daniel Borkmann Subject: Re: [PATCH bpf] selftests/bpf: bring back c++ include/link test Message-ID: <20191202214935.GA202854@mini-arch> References: <20191202202112.167120-1-sdf@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/02, Andrii Nakryiko wrote: > On Mon, Dec 2, 2019 at 12:28 PM Stanislav Fomichev wrote: > > +# Make sure we are able to include and link libbpf against c++. > > +$(OUTPUT)/test_cpp: test_cpp.cpp $(BPFOBJ) > > + $(CXX) $(CFLAGS) $^ -lelf -o $@ > > let's use $(LDLIBS) instead here Sure, I'll send a v2 with $(LDLIBS); it might be worth doing for consistency. Just curious: any particular reason you want to do it? (looking it tools/build/features, I don't see any possible -lelf cross-dependency)