From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C76C432C0 for ; Tue, 3 Dec 2019 09:29:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03AD1206EC for ; Tue, 3 Dec 2019 09:29:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nucleusys.com header.i=@nucleusys.com header.b="az+fiEGL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725954AbfLCJ3W (ORCPT ); Tue, 3 Dec 2019 04:29:22 -0500 Received: from lan.nucleusys.com ([92.247.61.126]:48534 "EHLO zztop.nucleusys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725773AbfLCJ3V (ORCPT ); Tue, 3 Dec 2019 04:29:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nucleusys.com; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SPTBtyeUeDRR5pMkwGpcKA7lJGGxvl9v/AEYGM05tuU=; b=az+fiEGL6xxCTkxgB/SCrGseNC pJjQk0IyR72IFFws/EvyIvb6xtbBZrZ8ANZydMxYnR+cv+r3fhUBlJ0m0mUnA/CHSheFrACIJOASd yXa2kHlqPEklbFCR4MGpfPZ3u1igFA8ZqVFEAh/x2ANpa5CYJL7D3dgvux57PMzCMRM8=; Received: from 78-83-66-117.spectrumnet.bg ([78.83.66.117] helo=carbon) by zztop.nucleusys.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ic4Ug-0004uq-TV; Tue, 03 Dec 2019 11:29:19 +0200 Date: Tue, 3 Dec 2019 11:29:18 +0200 From: Petko Manolov To: Thor Thayer Cc: netdev@vger.kernel.org Subject: Re: Altera TSE driver not working in 100mbps mode Message-ID: <20191203092918.52x3dfuvnryr5kpx@carbon> References: <20191127135419.7r53qw6vtp747x62@p310> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191127135419.7r53qw6vtp747x62@p310> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org All right, the first message got ignored so this is my take two. :) Has anyone stumbled on the same problem as me? cheers, Petko On 19-11-27 15:54:19, Petko Manolov wrote: > Hi Thor, > > In my effort to move Altera TSE driver from PHYLIB to PHYLINK i ran into a > problem. The driver would not work properly on 100Mbit/s links. This is true > for the original driver in linux-5.4.y as well as for my PHYLINK/SFP enabled > version. > > This is a DT fragment of what i've been trying with 5.4.y kernels and the > stock driver: > > tse_sub_2: ethernet@0xc0300000 { > status = "disabled"; > > compatible = "altr,tse-msgdma-1.0"; > reg = <0xc0300000 0x00000400>, > <0xc0301000 0x00000020>, > <0xc0302000 0x00000020>, > <0xc0303000 0x00000008>, > <0xc0304000 0x00000020>, > <0xc0305000 0x00000020>; > reg-names = "control_port", "rx_csr", "rx_desc", "rx_resp", "tx_csr", "tx_desc"; > interrupt-parent =< &intc >; > interrupts = <0 54 4>, <0 55 4>; > interrupt-names = "rx_irq", "tx_irq"; > rx-fifo-depth = <2048>; > tx-fifo-depth = <2048>; > address-bits = <48>; > max-frame-size = <1500>; > local-mac-address = [ 00 0C ED 00 00 06 ]; > altr,has-supplementary-unicast; > altr,has-hash-multicast-filter; > phy-handle = <0>; > fixed-link { > speed = <1000>; > full-duplex; > }; > }; > > Trying "speed = <100>;" above also doesn't change much, except that the link is > reported (as expected) as 100Mbps. > > With the PHYLINK code the above fragment is pretty much the same except for: > > sfp = <&sfp0>; > phy-mode = "sgmii"; > managed = "in-band-status"; > > Both (old and new) drivers are working fine on 1Gbps links with optics and > copper SFPs. With PHYLINK code (and in auto-negotiation mode) the link speed > and duplex is properly detected as 100Mbps. MAC and PCS also look correctly set > up, but the device is still unable to receive or transmit packages. > > > Please let me know should you need more details. > > > thanks, > Petko >