From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A12CAC432C0 for ; Tue, 3 Dec 2019 20:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 611FB2080A for ; Tue, 3 Dec 2019 20:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575404621; bh=vDly8YxF//Ih8pOGDzMUZMzO1IEy4IRZGxS7lQhxWgw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bqz2TMoEUpjbjJ0HL6oqKKXvDmcwcjVG19aDtH3s5wt1RNFGtfgM+NODPG5X2I0bV tnJwUSauw8YuZkykFe4tKypZqbjIbTCmYITQ7KExGEAVnOgiayzJ9fYcvKxetHGlar fsQ7DIogqDZLl7bALtvbPWvWTnAkeTiRnbC1grq0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727051AbfLCUXk (ORCPT ); Tue, 3 Dec 2019 15:23:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:50126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726079AbfLCUXk (ORCPT ); Tue, 3 Dec 2019 15:23:40 -0500 Received: from localhost (unknown [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D2B7206DF; Tue, 3 Dec 2019 20:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575404619; bh=vDly8YxF//Ih8pOGDzMUZMzO1IEy4IRZGxS7lQhxWgw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FmB8v1mwLOfhIaRIGvggEffzlPcugaQlSS6BdY0c0t9trnOhquORxZug0MqLtYIqh wcMs7VsyirUUob5q8s7Wk2lWw3cpCIhjrOcYJDbez38/vfPw0TWqB6m7Ylt47EUtNz Q2ttFqL43y5bs8FrySVqBGYDG7Bt0rv0RUGYm7YI= Date: Tue, 3 Dec 2019 21:23:28 +0100 From: Greg Kroah-Hartman To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , Soheil Hassas Yeganeh , Neal Cardwell , Yuchung Cheng , Willem de Bruijn Subject: Re: [PATCH net] tcp: refactor tcp_retransmit_timer() Message-ID: <20191203202328.GA3183510@kroah.com> References: <20191203160552.31071-1-edumazet@google.com> <20191203191314.GA2734645@kroah.com> <20191203192234.GA2735936@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Dec 03, 2019 at 11:30:29AM -0800, Eric Dumazet wrote: > On Tue, Dec 3, 2019 at 11:22 AM Greg Kroah-Hartman > wrote: > > > > On Tue, Dec 03, 2019 at 11:15:31AM -0800, Eric Dumazet wrote: > > > On Tue, Dec 3, 2019 at 11:13 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Tue, Dec 03, 2019 at 08:05:52AM -0800, Eric Dumazet wrote: > > > > > It appears linux-4.14 stable needs a backport of commit > > > > > 88f8598d0a30 ("tcp: exit if nothing to retransmit on RTO timeout") > > > > > > > > > > Since tcp_rtx_queue_empty() is not in pre 4.15 kernels, > > > > > let's refactor tcp_retransmit_timer() to only use tcp_rtx_queue_head() > > > > > > > > So does that mean that 4.19.y should get 88f8598d0a30 ("tcp: exit if > > > > nothing to retransmit on RTO timeout") as-is? > > > > > > > > > > Yes indeed. All stable versions need it. > > > > So 4.4.y and 4.9.y as well? > > They should be fine, since they do not have yet : > > ba2ddb43f270e6492ccce4fc42fc32c611de8f68 tcp: Don't dequeue > SYN/FIN-segments from write-queue > f1dcc5ed4bea3f2d63b74ad86617ec12b1e5e9d4 tcp: Reset send_head when > removing skb from write-queue > 8e6521f6404e704fac313ab2479923be1f741f73 tcp: remove empty skb from > write queue in error cases > > I would leave them untouched, to limit further problems :/ Great, thanks for letting me know. greg k-h