From: Stephen Hemminger <stephen@networkplumber.org>
To: Brian Vazquez <brianvv@google.com>
Cc: Brian Vazquez <brianvv.kernel@gmail.com>,
David Ahern <dsahern@gmail.com>,
Mahesh Bandewar <maheshb@google.com>,
Maciej Zenczykowski <maze@google.com>,
netdev@vger.kernel.org, Hritik Vijay <hritikxx8@gmail.com>,
Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCH iproute2 v2] ss: fix end-of-line printing in misc/ss.c
Date: Thu, 5 Dec 2019 12:24:52 -0800 [thread overview]
Message-ID: <20191205122452.5922112d@hermes.lan> (raw)
In-Reply-To: <20191204213228.164704-1-brianvv@google.com>
On Wed, 4 Dec 2019 13:32:28 -0800
Brian Vazquez <brianvv@google.com> wrote:
> The previous change to ss to show header broke the printing of
> end-of-line for the last entry.
>
> Tested:
> diff <(./ss.old -nltp) <(misc/ss -nltp)
> 38c38
> < LISTEN 0 128 [::1]:35417 [::]:* users:(("foo",pid=65254,fd=116))
> \ No newline at end of file
> ---
> > LISTEN 0 128 [::1]:35417 [::]:* users:(("foo",pid=65254,fd=116))
>
> Cc: Hritik Vijay <hritikxx8@gmail.com>
> Fixes: 5883c6eba517 ("ss: show header for --processes/-p")
> Signed-off-by: Brian Vazquez <brianvv@google.com>
> Tested-by: Michal Kubecek <mkubecek@suse.cz>
> ---
Applied
prev parent reply other threads:[~2019-12-05 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 21:32 [PATCH iproute2 v2] ss: fix end-of-line printing in misc/ss.c Brian Vazquez
2019-12-05 20:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205122452.5922112d@hermes.lan \
--to=stephen@networkplumber.org \
--cc=brianvv.kernel@gmail.com \
--cc=brianvv@google.com \
--cc=dsahern@gmail.com \
--cc=hritikxx8@gmail.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).