From: Guillaume Nault <gnault@redhat.com>
To: Aditya Pakki <pakki001@umn.edu>
Cc: klju@umn.edu, Michal Ostrowski <mostrows@earthlink.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pppoe: remove redundant BUG_ON() check in pppoe_pernet
Date: Fri, 6 Dec 2019 15:56:19 +0100 [thread overview]
Message-ID: <20191206145619.GA3930@linux.home> (raw)
In-Reply-To: <20191205230342.8548-1-pakki001@umn.edu>
On Thu, Dec 05, 2019 at 05:03:42PM -0600, Aditya Pakki wrote:
> Passing NULL to pppoe_pernet causes a crash via BUG_ON.
> Dereferencing net in net_generici() also has the same effect. This patch
> removes the redundant BUG_ON check on the same parameter.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/net/ppp/pppoe.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
> index a44dd3c8af63..d760a36db28c 100644
> --- a/drivers/net/ppp/pppoe.c
> +++ b/drivers/net/ppp/pppoe.c
> @@ -119,8 +119,6 @@ static inline bool stage_session(__be16 sid)
>
> static inline struct pppoe_net *pppoe_pernet(struct net *net)
> {
> - BUG_ON(!net);
> -
> return net_generic(net, pppoe_net_id);
> }
>
Looks like a net-next patch, but net-next is currently closed (take a
look Documentation/networking/netdev-FAQ.rst for details).
You can add my ack when you repost:
Acked-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2019-12-06 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 23:03 [PATCH] pppoe: remove redundant BUG_ON() check in pppoe_pernet Aditya Pakki
2019-12-05 23:05 ` David Miller
2019-12-06 14:56 ` Guillaume Nault [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-05 23:04 Aditya Pakki
2019-12-07 19:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206145619.GA3930@linux.home \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=klju@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).