From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV
Date: Fri, 6 Dec 2019 07:50:26 -0800 [thread overview]
Message-ID: <20191206155026.GE35479@atomide.com> (raw)
In-Reply-To: <c8058866-2be9-831c-19f6-31d17decb6f1@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [191206 11:08]:
> Hi Tony,
>
> On 04/12/2019 19:45, Grygorii Strashko wrote:
> > The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select
> > NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required
> > to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig.
> >
> > Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > ---
> > arch/arm/configs/omap2plus_defconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index 89cce8d4bc6b..7bbef86a4e76 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -92,6 +92,7 @@ CONFIG_IP_PNP_BOOTP=y
> > CONFIG_IP_PNP_RARP=y
> > CONFIG_NETFILTER=y
> > CONFIG_PHONET=m
> > +CONFIG_NET_SWITCHDEV=y
> > CONFIG_CAN=m
> > CONFIG_CAN_C_CAN=m
> > CONFIG_CAN_C_CAN_PLATFORM=m
> > @@ -182,6 +183,7 @@ CONFIG_SMSC911X=y
> > # CONFIG_NET_VENDOR_STMICRO is not set
> > CONFIG_TI_DAVINCI_EMAC=y
> > CONFIG_TI_CPSW=y
> > +CONFIG_TI_CPSW_SWITCHDEV=y
> > CONFIG_TI_CPTS=y
> > # CONFIG_NET_VENDOR_VIA is not set
> > # CONFIG_NET_VENDOR_WIZNET is not set
> > @@ -554,4 +556,3 @@ CONFIG_DEBUG_INFO_DWARF4=y
> > CONFIG_MAGIC_SYSRQ=y
> > CONFIG_SCHEDSTATS=y
> > # CONFIG_DEBUG_BUGVERBOSE is not set
> > -CONFIG_TI_CPSW_SWITCHDEV=y
> >
>
> Could it be applied as fix, as without it cpsw switch driver will not be built,
> so no networking on am571x-idk
OK I'll be applying it into fixes.
Thanks,
Tony
next prev parent reply other threads:[~2019-12-06 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 17:45 [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV Grygorii Strashko
2019-12-04 17:45 ` [PATCH 1/2] " Grygorii Strashko
2019-12-04 21:26 ` Randy Dunlap
2019-12-04 17:45 ` [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV Grygorii Strashko
2019-12-06 11:07 ` Grygorii Strashko
2019-12-06 15:50 ` Tony Lindgren [this message]
2019-12-05 22:39 ` [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV David Miller
2019-12-06 11:04 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206155026.GE35479@atomide.com \
--to=tony@atomide.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).