From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9104BC2BBE2 for ; Fri, 6 Dec 2019 15:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70770206DF for ; Fri, 6 Dec 2019 15:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbfLFPua (ORCPT ); Fri, 6 Dec 2019 10:50:30 -0500 Received: from muru.com ([72.249.23.125]:44222 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbfLFPua (ORCPT ); Fri, 6 Dec 2019 10:50:30 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 05DB48047; Fri, 6 Dec 2019 15:51:07 +0000 (UTC) Date: Fri, 6 Dec 2019 07:50:26 -0800 From: Tony Lindgren To: Grygorii Strashko Cc: Randy Dunlap , netdev@vger.kernel.org, "David S . Miller" , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV Message-ID: <20191206155026.GE35479@atomide.com> References: <20191204174533.32207-1-grygorii.strashko@ti.com> <20191204174533.32207-3-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org * Grygorii Strashko [191206 11:08]: > Hi Tony, > > On 04/12/2019 19:45, Grygorii Strashko wrote: > > The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select > > NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required > > to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig. > > > > Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver") > > Signed-off-by: Grygorii Strashko > > --- > > arch/arm/configs/omap2plus_defconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > > index 89cce8d4bc6b..7bbef86a4e76 100644 > > --- a/arch/arm/configs/omap2plus_defconfig > > +++ b/arch/arm/configs/omap2plus_defconfig > > @@ -92,6 +92,7 @@ CONFIG_IP_PNP_BOOTP=y > > CONFIG_IP_PNP_RARP=y > > CONFIG_NETFILTER=y > > CONFIG_PHONET=m > > +CONFIG_NET_SWITCHDEV=y > > CONFIG_CAN=m > > CONFIG_CAN_C_CAN=m > > CONFIG_CAN_C_CAN_PLATFORM=m > > @@ -182,6 +183,7 @@ CONFIG_SMSC911X=y > > # CONFIG_NET_VENDOR_STMICRO is not set > > CONFIG_TI_DAVINCI_EMAC=y > > CONFIG_TI_CPSW=y > > +CONFIG_TI_CPSW_SWITCHDEV=y > > CONFIG_TI_CPTS=y > > # CONFIG_NET_VENDOR_VIA is not set > > # CONFIG_NET_VENDOR_WIZNET is not set > > @@ -554,4 +556,3 @@ CONFIG_DEBUG_INFO_DWARF4=y > > CONFIG_MAGIC_SYSRQ=y > > CONFIG_SCHEDSTATS=y > > # CONFIG_DEBUG_BUGVERBOSE is not set > > -CONFIG_TI_CPSW_SWITCHDEV=y > > > > Could it be applied as fix, as without it cpsw switch driver will not be built, > so no networking on am571x-idk OK I'll be applying it into fixes. Thanks, Tony