From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com
Subject: Re: [Patch net] gre: refetch erspan header from skb->data after pskb_may_pull()
Date: Sat, 07 Dec 2019 11:54:20 -0800 (PST) [thread overview]
Message-ID: <20191207.115420.167629527884039167.davem@davemloft.net> (raw)
In-Reply-To: <20191206033902.19638-1-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Thu, 5 Dec 2019 19:39:02 -0800
> After pskb_may_pull() we should always refetch the header
> pointers from the skb->data in case it got reallocated.
>
> In gre_parse_header(), the erspan header is still fetched
> from the 'options' pointer which is fetched before
> pskb_may_pull().
>
> Found this during code review of a KMSAN bug report.
>
> Fixes: cb73ee40b1b3 ("net: ip_gre: use erspan key field for tunnel lookup")
> Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-12-07 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 3:39 [Patch net] gre: refetch erspan header from skb->data after pskb_may_pull() Cong Wang
2019-12-06 10:42 ` Simon Horman
2019-12-06 11:55 ` Lorenzo Bianconi
2019-12-07 17:04 ` Simon Horman
2019-12-06 11:49 ` Lorenzo Bianconi
2019-12-06 17:08 ` William Tu
2019-12-07 19:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191207.115420.167629527884039167.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).