From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Marco Oliverio <marco.oliverio@tanaza.com>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
fw@strlen.de, rocco.folino@tanaza.com
Subject: Re: [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst
Date: Sat, 7 Dec 2019 19:52:32 +0100 [thread overview]
Message-ID: <20191207185232.eau34ble7eigv2vq@salvia> (raw)
In-Reply-To: <20191202185430.31367-1-marco.oliverio@tanaza.com>
On Mon, Dec 02, 2019 at 07:54:30PM +0100, Marco Oliverio wrote:
> Bridge packets that are forwarded have skb->dst == NULL and get
> dropped by the check introduced by
> b60a77386b1d4868f72f6353d35dabe5fbe981f2 (net: make skb_dst_force
> return true when dst is refcounted).
>
> To fix this we check skb_dst() before skb_dst_force(), so we don't
> drop skb packet with dst == NULL. This holds also for skb at the
> PRE_ROUTING hook so we remove the second check.
Applied, thanks.
next prev parent reply other threads:[~2019-12-07 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 18:54 [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst Marco Oliverio
2019-12-02 18:58 ` Florian Westphal
2019-12-02 19:04 ` Marco Oliverio
2019-12-07 18:52 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-02 18:45 Marco Oliverio
2019-12-02 18:43 Marco Oliverio
2019-12-02 18:42 Marco Oliverio
2019-12-02 21:51 ` Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191207185232.eau34ble7eigv2vq@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=marco.oliverio@tanaza.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rocco.folino@tanaza.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox