From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB68C43603 for ; Mon, 9 Dec 2019 22:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CF6D2071E for ; Mon, 9 Dec 2019 22:37:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="vyHSIAwd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbfLIWhi (ORCPT ); Mon, 9 Dec 2019 17:37:38 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:40928 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbfLIWhh (ORCPT ); Mon, 9 Dec 2019 17:37:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h8hWfcWy+0CihgQ/Rci1+DvsV2Tdn8E9u3Vhs/z49wg=; b=vyHSIAwdt+uqCl7FYqs2td6lW 8IHxv2huQKt18iHUEYOBAkjPw43lz79hFJV9Mn7XYCoq+KKHjs4H33z5sW1m52bBCThgAbIW6sCGy RznuCIKTlDH0drQ6lwJKTfmlfxxyL9xxbleMn37Jo1P6VzB2Cg4cFpBQ6rNs0n7m+J53PUOx0qjxc GHev5KH1bs1VZlkZJKx3lso4S8hl0p/jfZJvqGXy8f9/5f9JLZw/mxq+QlGDso40XOcxksah0VMMR W+q8kRr1aoP8C7JoF29psmu0oTTgjzpM3DvKR+eK7sm42Zv7w+wduzjOZxCOa8BmSiM3urQHKXexS RgD6HaRKg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50792) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ieRek-0005rV-KR; Mon, 09 Dec 2019 22:37:30 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1ieRei-00040Z-Cx; Mon, 09 Dec 2019 22:37:28 +0000 Date: Mon, 9 Dec 2019 22:37:28 +0000 From: Russell King - ARM Linux admin To: David Miller Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules Message-ID: <20191209223728.GR25745@shell.armlinux.org.uk> References: <20191209141525.GK25745@shell.armlinux.org.uk> <20191209.143449.1221575502285244589.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191209.143449.1221575502285244589.davem@davemloft.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 09, 2019 at 02:34:49PM -0800, David Miller wrote: > From: Russell King - ARM Linux admin > Date: Mon, 9 Dec 2019 14:15:25 +0000 > > > This series, following on from the previous adding SFP+ copper support, > > adds support for a range of Copper SFP modules, made by a variety of > > companies, all of which have a Marvell 88E1111 PHY on them, but take > > far longer than the Marvell spec'd 15ms to start communicating on the > > I2C bus. > > > > Researching the Champion One 1000SFPT module reveals that TX_DISABLE is > > routed through a MAX1971 switching regulator and reset IC which adds a > > 175ms delay to releasing the 88E1111 reset. > > > > It is not known whether other modules use a similar setup, but there > > are a range of modules that are slow for the Marvell PHY to appear. > > > > This patch series adds support for these modules by repeatedly trying > > to probe the PHY for up to 600ms. > > Patch #3 gets full rejects when I try to apply this series. > > Please respin, adding Andrew's ACKs. As mentioned in the very first sentence, it depends on the previously submitted series, which hasn't yet been reviewed. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up