From: Andrew Lunn <andrew@lunn.ch>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jiri Pirko <jiri@resnulli.us>,
Florian Fainelli <f.fainelli@gmail.com>,
John Linville <linville@tuxdriver.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/5] ethtool: provide link mode names as a string set
Date: Tue, 10 Dec 2019 14:49:28 +0100 [thread overview]
Message-ID: <20191210134928.GC16369@lunn.ch> (raw)
In-Reply-To: <fe689865e1e8cda85dd0ca259c820c473bd9576c.1575982069.git.mkubecek@suse.cz>
On Tue, Dec 10, 2019 at 02:08:13PM +0100, Michal Kubecek wrote:
> Unlike e.g. netdev features, the ethtool ioctl interface requires link mode
> table to be in sync between kernel and userspace for userspace to be able
> to display and set all link modes supported by kernel. The way arbitrary
> length bitsets are implemented in netlink interface, this will be no longer
> needed.
>
> To allow userspace to access all link modes running kernel supports, add
> table of ethernet link mode names and make it available as a string set to
> userspace GET_STRSET requests. Add build time check to make sure names
> are defined for all modes declared in enum ethtool_link_mode_bit_indices.
>
> Once the string set is available, make it also accessible via ioctl.
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-12-10 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 13:07 [PATCH net-next v2 0/5] ethtool netlink interface, preliminary part Michal Kubecek
2019-12-10 13:07 ` [PATCH net-next v2 1/5] rtnetlink: provide permanent hardware address in RTM_NEWLINK Michal Kubecek
2019-12-10 17:51 ` Jakub Kicinski
2019-12-10 18:43 ` Jiri Pirko
2019-12-10 20:22 ` Johannes Berg
2019-12-10 20:23 ` Johannes Berg
2019-12-10 20:27 ` David Ahern
2019-12-10 20:29 ` Johannes Berg
2019-12-10 13:07 ` [PATCH net-next v2 2/5] netlink: rename nl80211_validate_nested() to nla_validate_nested() Michal Kubecek
2019-12-10 13:08 ` [PATCH net-next v2 3/5] ethtool: move to its own directory Michal Kubecek
2019-12-10 13:08 ` [PATCH net-next v2 4/5] ethtool: move string arrays into common file Michal Kubecek
2019-12-10 20:27 ` Johannes Berg
2019-12-11 8:24 ` Michal Kubecek
2019-12-10 13:08 ` [PATCH net-next v2 5/5] ethtool: provide link mode names as a string set Michal Kubecek
2019-12-10 13:49 ` Andrew Lunn [this message]
2019-12-10 14:27 ` Jiri Pirko
2019-12-10 17:51 ` [PATCH net-next v2 0/5] ethtool netlink interface, preliminary part Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210134928.GC16369@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).