From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C50AC2D0BF for ; Tue, 10 Dec 2019 17:51:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21F812073B for ; Tue, 10 Dec 2019 17:51:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="ivsPwB1Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727695AbfLJRvZ (ORCPT ); Tue, 10 Dec 2019 12:51:25 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:45598 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727520AbfLJRvY (ORCPT ); Tue, 10 Dec 2019 12:51:24 -0500 Received: by mail-ot1-f67.google.com with SMTP id 59so16257601otp.12 for ; Tue, 10 Dec 2019 09:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OLDxXwGsHcXK/4MIow1/s2R5pg50DmOvyjuxK3g9wtU=; b=ivsPwB1YTGoIqwpelldM6752S5Z3ZLBx8nEuNVlEjk4B/TTkZmCjast27dQ0FXwecW Pen2BRBdXB/75GSmtdEEV+lF9iyqgTBkQSHbj4RyWDUKm/Yhx1YjowNV77BwEhh577t4 9lKrfi4JhS1rJ33z17ZDtPqWiWntpERSfWLJlVbWgrGJf4Kl+fLQFoTF06fgeYhhQU9U piHCWHAD5N3Kjkx/Z065UO6A+0XdHCA+4rPms3NqkVqk+1sjj5s8LgR25lejSsjpkkVh dvsCgBGQ2kY11aPyCnDyiI0frsKbejdL/6iP5S/kWfwyPv9ZtXKeMCTJ2ntY4WaM3jWT gyPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OLDxXwGsHcXK/4MIow1/s2R5pg50DmOvyjuxK3g9wtU=; b=dZtQ1ngGTc9v/2cfYB0BBs3efII77h/TSKuNoI1RJo+f/9/iewLtAbC+ZD9eJfTVHX 0QlRj1ILlyLw5xQv2kvMxR0vekhjiP5PLmdc0N7/5K7ywAN22mpJOcZxj1byB1uy897r ZBLOp4mX2EvUiGmLivPSJVV7VMcnkMr06hawTEXjRr5DD61/39v/ZduF4nJW3RcmXYU8 mImKl1XoWkUTWxK7D9cY3Gqj7S8IGfq0a7e/x4DkGcTmZE65AySnPUig5zbe43x3T2S7 FPIdT9RhyS1I57f6vuLYOdruoS1g/uIYx3xI1LLT6/K8NpEWayHiPekewGlPnuRS3M/K Z4HQ== X-Gm-Message-State: APjAAAUj8cZbXOg8tPG0uBZAhtW8ZKPkpYxMhqY1bDcRxyOpqcJXNy68 qM4xGqYnGBLOsRYj9si/gcI9/g== X-Google-Smtp-Source: APXvYqwjZ7m8GoTodEQ8prrcN+kuiLnooUkBMxA02f4sb6i33XAgDNikDdssy6EDIffCBNIuNTjuOA== X-Received: by 2002:a9d:6b06:: with SMTP id g6mr26746974otp.93.1576000283694; Tue, 10 Dec 2019 09:51:23 -0800 (PST) Received: from ziepe.ca ([217.140.111.136]) by smtp.gmail.com with ESMTPSA id e17sm1628192otq.58.2019.12.10.09.51.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Dec 2019 09:51:22 -0800 (PST) Received: from jgg by LT-JGG-7470.mtl.com with local (Exim 4.90_1) (envelope-from ) id 1iejfN-00001O-El; Tue, 10 Dec 2019 13:51:21 -0400 Date: Tue, 10 Dec 2019 13:51:21 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: Jeff Kirsher , davem@davemloft.net, gregkh@linuxfoundation.org, Dave Ertman , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, parav@mellanox.com, Kiran Patil Subject: Re: [PATCH v3 01/20] virtual-bus: Implementation of Virtual Bus Message-ID: <20191210175121.GC46@ziepe.ca> References: <20191209224935.1780117-1-jeffrey.t.kirsher@intel.com> <20191209224935.1780117-2-jeffrey.t.kirsher@intel.com> <20191210064929.GJ67461@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191210064929.GJ67461@unreal> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Dec 10, 2019 at 08:49:29AM +0200, Leon Romanovsky wrote: > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("Lightweight Virtual Bus"); > > +MODULE_AUTHOR("David Ertman "); > > +MODULE_AUTHOR("Kiran Patil "); > > + > > +static DEFINE_IDA(virtbus_dev_ida); > > I was under impression that usage of IDA interface is discouraged in favor > of direct calls to XArray. IDA is OK, idr should be xarray Jason