* [PATCH] ptp: clockmatrix: add I2C dependency
@ 2019-12-10 19:56 Arnd Bergmann
2019-12-10 20:11 ` Vincent Cheng
2019-12-13 23:44 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-12-10 19:56 UTC (permalink / raw)
To: Richard Cochran, Vincent Cheng, David S. Miller
Cc: Arnd Bergmann, Yangbo Lu, Antonio Borneo, Thomas Gleixner,
YueHaibing, netdev, linux-kernel
Without I2C, we get a link failure:
drivers/ptp/ptp_clockmatrix.o: In function `idtcm_xfer.isra.3':
ptp_clockmatrix.c:(.text+0xcc): undefined reference to `i2c_transfer'
drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_init':
ptp_clockmatrix.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_exit':
ptp_clockmatrix.c:(.exit.text+0x10): undefined reference to `i2c_del_driver'
Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/ptp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index dc3d8ecb4231..e37797c0a85c 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -107,7 +107,7 @@ config PTP_1588_CLOCK_KVM
config PTP_1588_CLOCK_IDTCM
tristate "IDT CLOCKMATRIX as PTP clock"
- depends on PTP_1588_CLOCK
+ depends on PTP_1588_CLOCK && I2C
default n
help
This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ptp: clockmatrix: add I2C dependency
2019-12-10 19:56 [PATCH] ptp: clockmatrix: add I2C dependency Arnd Bergmann
@ 2019-12-10 20:11 ` Vincent Cheng
2019-12-13 23:44 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Vincent Cheng @ 2019-12-10 20:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Richard Cochran, David S. Miller, Yangbo Lu, Antonio Borneo,
Thomas Gleixner, YueHaibing, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
On Tue, Dec 10, 2019 at 02:56:34PM EST, Arnd Bergmann wrote:
>Without I2C, we get a link failure:
>
>drivers/ptp/ptp_clockmatrix.o: In function `idtcm_xfer.isra.3':
>ptp_clockmatrix.c:(.text+0xcc): undefined reference to `i2c_transfer'
>drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_init':
>ptp_clockmatrix.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
>drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_exit':
>ptp_clockmatrix.c:(.exit.text+0x10): undefined reference to `i2c_del_driver'
>
>Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> drivers/ptp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
>index dc3d8ecb4231..e37797c0a85c 100644
>--- a/drivers/ptp/Kconfig
>+++ b/drivers/ptp/Kconfig
>@@ -107,7 +107,7 @@ config PTP_1588_CLOCK_KVM
>
> config PTP_1588_CLOCK_IDTCM
> tristate "IDT CLOCKMATRIX as PTP clock"
>- depends on PTP_1588_CLOCK
>+ depends on PTP_1588_CLOCK && I2C
> default n
> help
> This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
>--
Sorry, that was flagged by "kbuild test robot" Nov 25.
I was in the process of creating a patch series with other updates,
but you beat me to the punch. Thank-you.
Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com>
Regards,
Vincent
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ptp: clockmatrix: add I2C dependency
2019-12-10 19:56 [PATCH] ptp: clockmatrix: add I2C dependency Arnd Bergmann
2019-12-10 20:11 ` Vincent Cheng
@ 2019-12-13 23:44 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-12-13 23:44 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Richard Cochran, Vincent Cheng, David S. Miller, Yangbo Lu,
Antonio Borneo, Thomas Gleixner, YueHaibing, netdev, linux-kernel
On Tue, 10 Dec 2019 20:56:34 +0100, Arnd Bergmann wrote:
> Without I2C, we get a link failure:
>
> drivers/ptp/ptp_clockmatrix.o: In function `idtcm_xfer.isra.3':
> ptp_clockmatrix.c:(.text+0xcc): undefined reference to `i2c_transfer'
> drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_init':
> ptp_clockmatrix.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
> drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_exit':
> ptp_clockmatrix.c:(.exit.text+0x10): undefined reference to `i2c_del_driver'
>
> Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to net, thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-13 23:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-10 19:56 [PATCH] ptp: clockmatrix: add I2C dependency Arnd Bergmann
2019-12-10 20:11 ` Vincent Cheng
2019-12-13 23:44 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).