From: "Daniel Walker (danielwa)" <danielwa@cisco.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Aviraj Cj (acj)" <acj@cisco.com>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>
Subject: Re: [PATCH 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor
Date: Tue, 10 Dec 2019 21:40:17 +0000 [thread overview]
Message-ID: <20191210214014.GV20426@zorba> (raw)
In-Reply-To: <20191210205542.GB4080658@kroah.com>
On Tue, Dec 10, 2019 at 09:55:42PM +0100, Greg KH wrote:
> On Tue, Dec 10, 2019 at 09:06:58AM -0800, Aviraj CJ wrote:
> > We always program the maximum DMA buffer size into the receive descriptor,
> > although the allocated size may be less. E.g. with the default MTU size
> > we allocate only 1536 bytes. If somebody sends us a bigger frame, then
> > memory may get corrupted.
> >
> > Program DMA using exact buffer sizes.
> >
> > [Adopted based on upstream commit c13a936f46e3321ad2426443296571fab2feda44
> > ("net: stmmac: use correct DMA buffer size in the RX descriptor")
> > by Aaro Koskinen <aaro.koskinen@nokia.com> ]
>
> Adopted to what?
>
> What is this patch for, it looks just like the commit you reference
> here.
>
> totally confused,
We're using the patches on the v4.4 -stable branch. It doesn't have these patches and
the backport had rejects.
Daniel
next prev parent reply other threads:[~2019-12-10 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 17:06 [PATCH 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor Aviraj CJ
2019-12-10 17:06 ` [PATCH 2/2] net: stmmac: don't stop NAPI processing when dropping a packet Aviraj CJ
2019-12-10 20:55 ` [PATCH 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor Greg KH
2019-12-10 21:40 ` Daniel Walker (danielwa) [this message]
2019-12-11 1:06 ` David Miller
2019-12-11 7:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210214014.GV20426@zorba \
--to=danielwa@cisco.com \
--cc=acj@cisco.com \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).