From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Jiri Pirko <jiri@resnulli.us>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
John Linville <linville@tuxdriver.com>,
Stephen Hemminger <stephen@networkplumber.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/5] ethtool: move string arrays into common file
Date: Wed, 11 Dec 2019 09:24:49 +0100 [thread overview]
Message-ID: <20191211082449.GC22512@unicorn.suse.cz> (raw)
In-Reply-To: <b48794642a7982e2ba97b571fadfd90e08d64d02.camel@sipsolutions.net>
On Tue, Dec 10, 2019 at 09:27:54PM +0100, Johannes Berg wrote:
>
> > +++ b/net/ethtool/common.c
> > @@ -0,0 +1,85 @@
> > +// SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
>
> Is the Linux-syscall-note relevant here? This isn't really used for
> syscalls directly?
>
> The exception says it's "to mark user space API (uapi) header files so
> they can be included into non GPL compliant user space application
> code".
I'm hardly an expert but almost all occurences of "Linux-syscall-note"
are in UAPI headers so you are most likely right. IIRC I copied the line
into include/uapi/linux/ethtool_netlink.h (which was the first new file)
from neighbor ethtool.h and then used the same in all other files.
I'll send a v3 with "GPL-2.0-only" (as there also seems to be a trend of
moving to SPDX v3 identifiers) in a moment.
Michal
>
> > +++ b/net/ethtool/common.h
> > @@ -0,0 +1,17 @@
> > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
>
> Same here.
>
> johannes
>
next prev parent reply other threads:[~2019-12-11 8:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 13:07 [PATCH net-next v2 0/5] ethtool netlink interface, preliminary part Michal Kubecek
2019-12-10 13:07 ` [PATCH net-next v2 1/5] rtnetlink: provide permanent hardware address in RTM_NEWLINK Michal Kubecek
2019-12-10 17:51 ` Jakub Kicinski
2019-12-10 18:43 ` Jiri Pirko
2019-12-10 20:22 ` Johannes Berg
2019-12-10 20:23 ` Johannes Berg
2019-12-10 20:27 ` David Ahern
2019-12-10 20:29 ` Johannes Berg
2019-12-10 13:07 ` [PATCH net-next v2 2/5] netlink: rename nl80211_validate_nested() to nla_validate_nested() Michal Kubecek
2019-12-10 13:08 ` [PATCH net-next v2 3/5] ethtool: move to its own directory Michal Kubecek
2019-12-10 13:08 ` [PATCH net-next v2 4/5] ethtool: move string arrays into common file Michal Kubecek
2019-12-10 20:27 ` Johannes Berg
2019-12-11 8:24 ` Michal Kubecek [this message]
2019-12-10 13:08 ` [PATCH net-next v2 5/5] ethtool: provide link mode names as a string set Michal Kubecek
2019-12-10 13:49 ` Andrew Lunn
2019-12-10 14:27 ` Jiri Pirko
2019-12-10 17:51 ` [PATCH net-next v2 0/5] ethtool netlink interface, preliminary part Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211082449.GC22512@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).