From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1773FC00454 for ; Wed, 11 Dec 2019 13:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E98F7214AF for ; Wed, 11 Dec 2019 13:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729518AbfLKNdF (ORCPT ); Wed, 11 Dec 2019 08:33:05 -0500 Received: from www62.your-server.de ([213.133.104.62]:33956 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727477AbfLKNdF (ORCPT ); Wed, 11 Dec 2019 08:33:05 -0500 Received: from [2001:1620:665:0:5795:5b0a:e5d5:5944] (helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1if26w-0005zf-Te; Wed, 11 Dec 2019 14:33:02 +0100 Date: Wed, 11 Dec 2019 14:33:02 +0100 From: Daniel Borkmann To: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: Jakub Kicinski , Alexei Starovoitov , lkml , netdev@vger.kernel.org, bpf@vger.kernel.org, Martin Lau Subject: Re: [PATCH bpf v2] bpftool: Don't crash on missing jited insns or ksyms Message-ID: <20191211133302.GD23383@linux.fritz.box> References: <20191210181412.151226-1-toke@redhat.com> <20191210125457.13f7821a@cakuba.netronome.com> <87eexbhopo.fsf@toke.dk> <20191211130857.GB23383@linux.fritz.box> <87zhfzf184.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zhfzf184.fsf@toke.dk> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25660/Wed Dec 11 10:47:07 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Dec 11, 2019 at 02:20:11PM +0100, Toke Høiland-Jørgensen wrote: > Daniel Borkmann writes: > > On Tue, Dec 10, 2019 at 10:09:55PM +0100, Toke Høiland-Jørgensen wrote: > > [...] > >> Anyhow, I don't suppose it'll hurt to have the Fixes: tag(s) in there; > >> does Patchwork pick these up (or can you guys do that when you apply > >> this?), or should I resend? > > > > Fixes tags should /always/ be present if possible, since they help to provide > > more context even if the buggy commit was in bpf-next, for example. > > ACK, will do. Thank you for picking them up for this patch (did you do > that manually, or is this part of your scripts?) Manually right now, but if you have some cycles, happy to pick up a patch [0]. :) [0] https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/pw.git/