From: Marek Behun <marek.behun@nic.cz>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
netdev@vger.kernel.org,
Denis Odintsov <d.odintsov@traviangames.com>,
Hubert Feurstein <h.feurstein@gmail.com>
Subject: Re: [BUG] mv88e6xxx: tx regression in v5.3
Date: Thu, 12 Dec 2019 19:32:18 +0100 [thread overview]
Message-ID: <20191212193218.2f91df52@nic.cz> (raw)
In-Reply-To: <20191212181729.mviz5c26ysebg4w3@sapphire.tkos.co.il>
On Thu, 12 Dec 2019 20:17:29 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
> This is not enough to fix v5.4, though. Commit 7a3007d22e8dc ("net: dsa:
> mv88e6xxx: fully support SERDES on Topaz family") breaks switch Tx on SolidRun
> Clearfog GT-8K in much the same way. I could not easily revert 7a3007d22e8dc
> on top of v5.4, but this is enough to make Tx work again with v5.4:
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 7b5b73499e37..e7e6400a994e 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -3191,7 +3191,6 @@ static const struct mv88e6xxx_ops mv88e6141_ops = {
> .port_disable_pri_override = mv88e6xxx_port_disable_pri_override,
> .port_link_state = mv88e6352_port_link_state,
> .port_get_cmode = mv88e6352_port_get_cmode,
> - .port_set_cmode = mv88e6341_port_set_cmode,
> .port_setup_message_port = mv88e6xxx_setup_message_port,
> .stats_snapshot = mv88e6390_g1_stats_snapshot,
> .stats_set_histogram = mv88e6095_g1_stats_set_histogram,
>
> Marek, do you have any idea how to properly fix this?
>
> Thanks,
> baruch
>
Hi Baruch,
can you tell on which port the port_set_cmode is called when things
break? Because if it is other than port 5, than method
mv88e6341_port_set_cmode does nothing. If it is port 5, do you have cpu
connected to the switch via port 5? What phy mode?
Marek
next prev parent reply other threads:[~2019-12-12 18:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 9:48 [BUG] mv88e6xxx: tx regression in v5.3 Baruch Siach
2019-12-11 13:11 ` Andrew Lunn
2019-12-11 17:07 ` Baruch Siach
2019-12-11 17:49 ` Andrew Lunn
2019-12-12 8:50 ` Baruch Siach
2019-12-12 13:14 ` Andrew Lunn
2019-12-12 14:19 ` Andreas Tobler
2019-12-12 15:08 ` Baruch Siach
2019-12-12 15:13 ` Andrew Lunn
2019-12-12 15:23 ` Baruch Siach
2019-12-12 18:17 ` Baruch Siach
2019-12-12 18:32 ` Marek Behun [this message]
2019-12-12 18:48 ` Baruch Siach
2019-12-12 18:36 ` Marek Behun
2019-12-12 19:06 ` Baruch Siach
2019-12-12 19:31 ` Andrew Lunn
2019-12-12 19:41 ` Marek Behun
2019-12-12 20:49 ` Andrew Lunn
2019-12-15 10:13 ` Baruch Siach
2019-12-15 11:10 ` Baruch Siach
2019-12-15 14:53 ` Andrew Lunn
2019-12-15 15:08 ` Baruch Siach
2019-12-15 16:14 ` Andrew Lunn
2019-12-17 18:26 ` Baruch Siach
2019-12-18 14:30 ` Marek Behún
2019-12-18 16:04 ` Baruch Siach
2019-12-19 9:04 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212193218.2f91df52@nic.cz \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=d.odintsov@traviangames.com \
--cc=h.feurstein@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).