From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Richard Cochran <richardcochran@gmail.com>,
Vincent Cheng <vincent.cheng.xh@renesas.com>,
"David S. Miller" <davem@davemloft.net>,
Yangbo Lu <yangbo.lu@nxp.com>,
Antonio Borneo <antonio.borneo@st.com>,
Thomas Gleixner <tglx@linutronix.de>,
YueHaibing <yuehaibing@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: clockmatrix: add I2C dependency
Date: Fri, 13 Dec 2019 15:44:29 -0800 [thread overview]
Message-ID: <20191213154429.00ffbebb@cakuba.netronome.com> (raw)
In-Reply-To: <20191210195648.811120-1-arnd@arndb.de>
On Tue, 10 Dec 2019 20:56:34 +0100, Arnd Bergmann wrote:
> Without I2C, we get a link failure:
>
> drivers/ptp/ptp_clockmatrix.o: In function `idtcm_xfer.isra.3':
> ptp_clockmatrix.c:(.text+0xcc): undefined reference to `i2c_transfer'
> drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_init':
> ptp_clockmatrix.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
> drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_exit':
> ptp_clockmatrix.c:(.exit.text+0x10): undefined reference to `i2c_del_driver'
>
> Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to net, thank you!
prev parent reply other threads:[~2019-12-13 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 19:56 [PATCH] ptp: clockmatrix: add I2C dependency Arnd Bergmann
2019-12-10 20:11 ` Vincent Cheng
2019-12-13 23:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213154429.00ffbebb@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=antonio.borneo@st.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
--cc=vincent.cheng.xh@renesas.com \
--cc=yangbo.lu@nxp.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).