From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE14C3435F for ; Fri, 13 Dec 2019 20:40:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F51424765 for ; Fri, 13 Dec 2019 20:40:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lbiw5D6I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbfLMS3G (ORCPT ); Fri, 13 Dec 2019 13:29:06 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:55836 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728792AbfLMS3F (ORCPT ); Fri, 13 Dec 2019 13:29:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576261744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EuipFtcR9CV/PUK4gZJD69/BC6ZNJnPtOUYxgz6hIYs=; b=Lbiw5D6Ienk9rSXCuN6ilACSV5mCmYDnk5S+00GDAogIgLH7oqT4UQvN2IuA1kIPe2x44p laaQigM+PiOlDVucAuh8KFrSKO9ksmn3o2PO325LQjQZOSwqGtmsQMLCPn0JZX3htva/Yy BXu0vmgKook+rYFByH3Ek74qLVWID2k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-8BbtPYfgOsqEYAs5wK98og-1; Fri, 13 Dec 2019 13:29:02 -0500 X-MC-Unique: 8BbtPYfgOsqEYAs5wK98og-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B880F107ACC5; Fri, 13 Dec 2019 18:28:59 +0000 (UTC) Received: from krava (ovpn-204-48.brq.redhat.com [10.40.204.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74C2519C4F; Fri, 13 Dec 2019 18:28:50 +0000 (UTC) Date: Fri, 13 Dec 2019 19:28:47 +0100 From: Jiri Olsa To: Alexei Starovoitov , Peter Zijlstra Cc: Steven Rostedt , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Andrii Nakryiko , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Networking , bpf , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Jesper Dangaard Brouer , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Quentin Monnet Subject: Re: [RFC] btf: Some structs are doubled because of struct ring_buffer Message-ID: <20191213182847.GA8994@krava> References: <20191213153553.GE20583@krava> <20191213112438.773dff35@gandalf.local.home> <20191213165155.vimm27wo7brkh3yu@ast-mbp.dhcp.thefacebook.com> <20191213121118.236f55b8@gandalf.local.home> <20191213173016.posmo4pxjwjvv4bh@ast-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213173016.posmo4pxjwjvv4bh@ast-mbp.dhcp.thefacebook.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Dec 13, 2019 at 09:30:18AM -0800, Alexei Starovoitov wrote: > On Fri, Dec 13, 2019 at 12:11:18PM -0500, Steven Rostedt wrote: > > On Fri, 13 Dec 2019 08:51:57 -0800 > > Alexei Starovoitov wrote: > > > > > It had two choices. Both valid. I don't know why gdb picked this one. > > > So yeah I think renaming 'ring_buffer' either in ftrace or in perf would be > > > good. I think renaming ftrace one would be better, since gdb picked perf one > > > for whatever reason. > > > > Because of the sort algorithm. But from a technical perspective, the > > ring buffer that ftrace uses is generic, where the perf ring buffer can > > only be used for perf. Call it "event_ring_buffer" or whatever, but > > it's not generic and should not have a generic name. > > I don't mind whichever way. Just saying it would be good to rename :) > Peter, any chance we could use the 'struct perf_buffer' for perf? thanks, jirka