From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12989C2D0C9 for ; Sat, 14 Dec 2019 07:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF2AE20724 for ; Sat, 14 Dec 2019 07:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725900AbfLNHTX (ORCPT ); Sat, 14 Dec 2019 02:19:23 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:29478 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbfLNHTW (ORCPT ); Sat, 14 Dec 2019 02:19:22 -0500 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id xBE7J7f9002928; Sat, 14 Dec 2019 08:19:07 +0100 Date: Sat, 14 Dec 2019 08:19:07 +0100 From: Willy Tarreau To: Jakub Kicinski Cc: Russell King , "David S. Miller" , Antoine Tenart , Andrew Lunn , Thomas Bogendoerfer , maxime.chevallier@bootlin.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: marvell: mvpp2: phylink requires the link interrupt Message-ID: <20191214071907.GA2925@1wt.eu> References: <20191213163403.2a054262@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213163403.2a054262@cakuba.netronome.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Dec 13, 2019 at 04:34:03PM -0800, Jakub Kicinski wrote: > On Tue, 10 Dec 2019 22:33:05 +0000, Russell King wrote: > > phylink requires the MAC to report when its link status changes when > > operating in inband modes. Failure to report link status changes > > means that phylink has no idea when the link events happen, which > > results in either the network interface's carrier remaining up or > > remaining permanently down. > > > > For example, with a fiber module, if the interface is brought up and > > link is initially established, taking the link down at the far end > > will cut the optical power. The SFP module's LOS asserts, we > > deactivate the link, and the network interface reports no carrier. > > > > When the far end is brought back up, the SFP module's LOS deasserts, > > but the MAC may be slower to establish link. If this happens (which > > in my tests is a certainty) then phylink never hears that the MAC > > has established link with the far end, and the network interface is > > stuck reporting no carrier. This means the interface is > > non-functional. > > > > Avoiding the link interrupt when we have phylink is basically not > > an option, so remove the !port->phylink from the test. > > > > Tested-by: Sven Auhagen > > Tested-by: Antoine Tenart > > Signed-off-by: Russell King > > Fixes: 4bb043262878 ("net: mvpp2: phylink support") ? > > Seems like you maybe didn't want this backported to stable hence > no fixes tag? > > Please advise :) Speaking for myself, I'd very much like to get it into stable in order to avoid having to keep this local patch on top of latest stable! Willy